feat: resolve environments plugins at config time #20120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patak-dev
commented
May 27, 2025
patak-dev
added
feat: environment API
sapphi-red
reviewed
May 28, 2025
packages/vite/src/node/config.ts
Outdated
| @@ -1450,10 +1453,20 @@ export async function resolveConfig( | |||
| .getSortedPluginHooks('configResolved') | |||
| .map((hook) => hook.call(resolvedConfigContext, workerResolved)), | |||
| ) | |||
| ;(workerResolved.plugins as Plugin[]) = resolvedWorkerPlugins | |||
There was a problem hiding this comment.
Could we have a comment that explains why this need to mutate workerResolved.plugins? Also do we also need to mutate workerResolved.environments, or is that fine?
There was a problem hiding this comment.
Added comments, and rearranged the code so it is easier to follow (hopefully). Also avoided recreating the worker resolved config after passing it to hooks (as they may store a reference) and fixed resolvedConfig for hooks, that should be after resolve the environment plugins ad08fee
sapphi-red
reviewed
May 29, 2025
sapphi-red
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently discussed with @dominikg about environment plugins resolutions and he asked how to access the resolved plugins for a given environment. These are currently present at
environment.pluginsonce the instance are inited. So during dev, there is the need to wait after server listen.We decided to pass a
PartialEnvironmenttoapplyToEnvironmentto avoid committing to resolving the plugins after the Environment instance are created, and leave the door open to move the resolution to config time. This PR explores this change.The benefits are:
resolvedConfig.environments[name].plugins.configResolvedcan be used to read this values.config.pluginsalways worked (they are fixed at config time, not after the server is created)The main difference with creating the plugins in the Environment instance is that if two Environments are created with the same config, they will share the environment plugins after this PR. We only allow a single server per ResolvedConfig, and we should do the same for Environments so this doesn't seems like an issue to me.