-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
feat: forward runtime error logs to server #20916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hi-ogawa
wants to merge
17
commits into
vitejs:main
Choose a base branch
from
hi-ogawa:10-10-feat_log_unhandled_runtime_error_on_server
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: forward runtime error logs to server #20916
hi-ogawa
wants to merge
17
commits into
vitejs:main
from
hi-ogawa:10-10-feat_log_unhandled_runtime_error_on_server
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
server.forwardRuntimeLogs
option, which enables forwarding unhandled runtime errors from browser to dev server and logs them on terminal.I mostly ported Vitest's error reporting logic and it even bundles a part of
@vitest/utils
for stack trace parsing (the output below looks so familiar 😄). The code size is expected to be compact and proved to be robust, so I think this approach is fine.I initially implemented in https://github.com/hi-ogawa/reproductions/tree/main/vite-20487-unhandled-error-to-console/runtime-log and userland plugin is possible (though with a caveat that ssr framework requires a way to inject script other than
transformIndexHtml
.)TODO
server.forwardRuntimeLogs
considering the future scope)console.error
? (e.g.react hydration error is not runtime but only console.errorNo, this wasn't the case.)process.on
like Vitest)get_errors
MCP endpoint vercel/next.js#84161)Related plugins
Example
Example: Github Copilot fixing bug by checking server logs
https://github.com/hi-ogawa/reproductions/tree/main/vite-20916-demo