feat: add client-side builtin module check in module runner #20924
+235
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #20840
This PR moves the isBuiltin check from the server side to the module runner side to avoid unnecessary server round-trips when importing builtin modules (e.g.,
node:fs
,node:path
).Module runner checks builtin modules client-side first. The server-side check remains as a fallback for custom runner implementations.
Changes
builtins
option to ModuleRunnerOptions interfacebuiltins
config to runner