Skip to content

Conversation

jiji-hoon96
Copy link

Description

Fixes #20840

This PR moves the isBuiltin check from the server side to the module runner side to avoid unnecessary server round-trips when importing builtin modules (e.g., node:fs, node:path).

Module runner checks builtin modules client-side first. The server-side check remains as a fallback for custom runner implementations.

Changes

  • Added createIsBuiltin utility in module-runner/utils.ts
  • Added builtins option to ModuleRunnerOptions interface
  • Module runner performs client-side builtin check before calling server
  • createServerModuleRunner automatically passes builtins config to runner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do the isBuiltin check on module runner side

1 participant