test: reduce commit wait time flaky test TestReadingUnresolvedTransactions #18017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions Signed-off-by: Harshit Gangal <[email protected]>
harshit-gangal
requested review from
systay,
frouioui and
GuptaManan100
as code owners
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18017 +/- ##
=======================================
Coverage 67.58% 67.58%
=======================================
Files 1598 1598
Lines 260270 260304 +34
=======================================
+ Hits 175902 175931 +29
- Misses 84368 84373 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
harshit-gangal
added
Component: Query Serving
Type: Testing
Backport to: release-21.0
| @@ -1065,7 +1065,7 @@ func TestReadingUnresolvedTransactions(t *testing.T) { | |||
| // We want to delay the commit on one of the shards to simulate slow commits on a shard. | |||
| twopcutil.WriteTestCommunicationFile(t, twopcutil.DebugDelayCommitShard, "80-") | |||
| defer twopcutil.DeleteFile(twopcutil.DebugDelayCommitShard) | |||
| twopcutil.WriteTestCommunicationFile(t, twopcutil.DebugDelayCommitTime, "5") | |||
| twopcutil.WriteTestCommunicationFile(t, twopcutil.DebugDelayCommitTime, "2") | |||
There was a problem hiding this comment.
Won't this make the test more flaky? We are checking later that the commit is still unresolved and this is the amount of time we delay the commit by. So reducing it will make the test more flaky
There was a problem hiding this comment.
We should instead increase the unhealthy threshold so that vtgate doesn't fix the transaction outside of the commit flow.
There was a problem hiding this comment.
Other test depends they resolve faster. I can take a look.
But this is enough time as we wait for 1sec only before checking the state. So keeping the delay for 5s would not help.
frouioui
approved these changes
Mar 25, 2025
This was referenced Apr 1, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the flakiness in
TestReadingUnresolvedTransactionsThe test was intermittently failing with the following error:
Error in commit: read tcp 127.0.0.1:56260->127.0.0.1:17038: use of closed network connectionThe failure occurred because VTGate resolved the commit outside of the current session received via the transaction watcher, leading to an unexpected connection closure on the current commit session.
To fix this, the commit wait time has been reduced to minimize the likelihood of transaction getting resolved via transaction resolution route.
Related Issue(s)
Checklist
Deployment Notes