Skip to content

Rebase flags-refactor branch with latest main updates to sync workflow and code changes #18112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 75 commits into
base: flags-refactor
Choose a base branch
from

Conversation

mounicasruthi
Copy link
Collaborator

@mounicasruthi mounicasruthi commented Apr 3, 2025

Description

The flags-refactor branch is currently behind main by 75 commits, including updates to .github/workflows and other improvements. This PR rebases flags-refactor with main to bring it up to date with the latest changes.

Related Issue(s)

N/A

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

GuptaManan100 and others added 30 commits March 10, 2025 17:15
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: Florent Poinsard <[email protected]>
Signed-off-by: Rafer Hazen <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: Florent Poinsard <[email protected]>
vitess-bot and others added 7 commits April 2, 2025 23:33
Signed-off-by: GitHub <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: frouioui <[email protected]>
Co-authored-by: Florent Poinsard <[email protected]>
… use dashes (vitessio#17964)

Signed-off-by: mounicasruthi <[email protected]>
Signed-off-by: Mounica Sruthi <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Co-authored-by: Deepthi Sigireddi <[email protected]>
Co-authored-by: Rohit Nayak <[email protected]>
Signed-off-by: mounicasruthi <[email protected]>
Signed-off-by: Mounica Sruthi <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Co-authored-by: Deepthi Sigireddi <[email protected]>
Co-authored-by: Rohit Nayak <[email protected]>
Copy link
Contributor

vitess-bot bot commented Apr 3, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Apr 3, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Apr 3, 2025
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

Attention: Patch coverage is 70.20649% with 101 lines in your changes missing coverage. Please review.

Project coverage is 67.57%. Comparing base (0bf4276) to head (99bb0c5).
Report is 2 commits behind head on flags-refactor.

Files with missing lines Patch % Lines
go/cmd/vtctldclient/command/backups.go 18.75% 13 Missing ⚠️
go/sqltypes/value.go 71.42% 12 Missing ⚠️
go/mysql/flavor_mysql.go 52.63% 9 Missing ⚠️
go/mysql/flavor_filepos.go 0.00% 8 Missing ⚠️
go/mysql/flavor_mariadb_binlog_playback.go 0.00% 8 Missing ⚠️
go/cmd/vtctldclient/command/onlineddl.go 25.00% 6 Missing ⚠️
go/cmd/vtctldclient/command/schema.go 0.00% 6 Missing ⚠️
go/vt/mysqlctl/mysqlshellbackupengine.go 50.00% 5 Missing ⚠️
go/mysql/flavor_mysqlgr.go 0.00% 4 Missing ⚠️
go/cmd/vtaclcheck/vtaclcheck.go 0.00% 3 Missing ⚠️
... and 15 more
Additional details and impacted files
@@                Coverage Diff                @@
##           flags-refactor   #18112     +/-   ##
=================================================
  Coverage           67.56%   67.57%             
=================================================
  Files                1597     1602      +5     
  Lines              259763   261419   +1656     
=================================================
+ Hits               175506   176641   +1135     
- Misses              84257    84778    +521     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says
Projects
None yet
Development

Successfully merging this pull request may close these issues.