Skip to content

[release-21.0] Properly handle grpc dial errors in the throttler metric aggregation (#18073) #18230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vitess-bot wants to merge 1 commit into from
Closed

[release-21.0] Properly handle grpc dial errors in the throttler metric aggregation (#18073) #18230

vitess-bot wants to merge 1 commit into from

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Apr 30, 2025

Description

This is a backport of #18073

@vitess-bot vitess-bot bot requested a review from harshit-gangal as a code owner April 30, 2025 18:54
@vitess-bot vitess-bot bot added Backport This is a backport Component: Throttler labels Apr 30, 2025
@vitess-bot vitess-bot bot requested a review from systay as a code owner April 30, 2025 18:54
@vitess-bot vitess-bot bot added the Type: Bug label Apr 30, 2025
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Apr 30, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot requested a review from arthurschreiber April 30, 2025 18:54
@github-actions github-actions bot added this to the v21.0.5 milestone Apr 30, 2025
@arthurschreiber arthurschreiber force-pushed the backport-18073-to-release-21.0 branch from d4409b4 to c3eb4cc Compare May 6, 2025 08:46
@vitess-bot @mhamza15 @arthurschreiber
Properly handle grpc dial errors in the throttler metric aggregation (#…
7296180 
…18073)

Signed-off-by: Arthur Schreiber <[email protected]>
Signed-off-by: Mohamed Hamza <[email protected]>
Co-authored-by: Mohamed Hamza <[email protected]>
@arthurschreiber arthurschreiber force-pushed the backport-18073-to-release-21.0 branch from c3eb4cc to 7296180 Compare May 6, 2025 09:01
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Jun 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2025

This PR was closed because it has been stale for 7 days with no activity.

@github-actions github-actions bot closed this Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arthurschreiber arthurschreiber arthurschreiber approved these changes

@frouioui frouioui frouioui approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@timvaillancourt timvaillancourt Awaiting requested review from timvaillancourt timvaillancourt is a code owner

Assignees

No one assigned

Labels

Backport This is a backport Component: Throttler Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. Type: Bug

Projects

None yet

Milestone

v21.0.5

Development

Successfully merging this pull request may close these issues.

3 participants

@arthurschreiber @frouioui