Skip to content

Use LD_PRELOAD instead of wrapping with eatmydata. #18709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Use LD_PRELOAD instead of wrapping with eatmydata. #18709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d3c438f
Use `LD_PRELOAD` instead of wrapping with `eatmydata`.
arthurschreiber Sep 30, 2025
37715d6
Enable libeatmydata when running `make tools`.
arthurschreiber Sep 30, 2025
6f01089
Install `eatmydata` earlier, so we can enable it for more setup steps.
arthurschreiber Sep 30, 2025
3b805a1
Only run `apt-get update` once.
arthurschreiber Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions .github/workflows/unit_test_evalengine_mysql57.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,22 @@ jobs:
echo "set man-db/auto-update false" | sudo debconf-communicate
sudo dpkg-reconfigure man-db

- name: Update apt
if: steps.changes.outputs.unit_tests == 'true'
run: |
sudo apt-get update

- name: Install eatmydata
if: steps.changes.outputs.unit_tests == 'true'
run: |
sudo apt-get install -y --no-install-recommends eatmydata

- name: Get dependencies
if: steps.changes.outputs.unit_tests == 'true'
env:
LD_PRELOAD: "libeatmydata.so"
run: |
export DEBIAN_FRONTEND="noninteractive"
sudo apt-get update

# Uninstall any previously installed MySQL first
# sudo systemctl stop apparmor
Expand Down Expand Up @@ -115,7 +126,7 @@ jobs:
sudo dpkg -i libtinfo5_6.3-2ubuntu0.1_amd64.deb
sudo DEBIAN_FRONTEND="noninteractive" apt-get install -y mysql-client=5.7* mysql-community-server=5.7* mysql-server=5.7* libncurses6

sudo apt-get install -y make unzip g++ curl git wget ant openjdk-11-jdk eatmydata
sudo apt-get install -y make unzip g++ curl git wget ant openjdk-11-jdk

sudo service mysql stop
sudo bash -c "echo '/usr/sbin/mysqld { }' > /etc/apparmor.d/usr.sbin.mysqld" # https://bugs.launchpad.net/ubuntu/+source/mariadb-10.1/+bug/1806263
Expand All @@ -134,11 +145,15 @@ jobs:

- name: Run make tools
if: steps.changes.outputs.unit_tests == 'true'
env:
LD_PRELOAD: "libeatmydata.so"
run: |
make tools

- name: Setup launchable dependencies
if: github.event_name == 'pull_request' && github.event.pull_request.draft == 'false' && steps.changes.outputs.unit_tests == 'true' && github.base_ref == 'main'
env:
LD_PRELOAD: "libeatmydata.so"
run: |
# Get Launchable CLI installed. If you can, make it a part of the builder image to speed things up
pip3 install --user launchable~=1.0 > /dev/null
Expand All @@ -152,6 +167,8 @@ jobs:
- name: Run test
if: steps.changes.outputs.unit_tests == 'true'
timeout-minutes: 30
env:
LD_PRELOAD: "libeatmydata.so"
run: |
set -exo pipefail
# We set the VTDATAROOT to the /tmp folder to reduce the file path of mysql.sock file
Expand All @@ -164,8 +181,8 @@ jobs:
# We sometimes need to alter the behavior based on the platform we're
# testing, e.g. MySQL 5.7 vs 8.0.
export CI_DB_PLATFORM="mysql57"
eatmydata -- make unit_test | tee -a output.txt | go-junit-report -set-exit-code > report.xml

make unit_test | tee -a output.txt | go-junit-report -set-exit-code > report.xml

- name: Record test results in launchable if PR is not a draft
if: github.event_name == 'pull_request' && github.event.pull_request.draft == 'false' && steps.changes.outputs.unit_tests == 'true' && github.base_ref == 'main' && !cancelled()
Expand Down
25 changes: 21 additions & 4 deletions .github/workflows/unit_test_evalengine_mysql80.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,22 @@ jobs:
echo "set man-db/auto-update false" | sudo debconf-communicate
sudo dpkg-reconfigure man-db

- name: Update apt
if: steps.changes.outputs.unit_tests == 'true'
run: |
sudo apt-get update

- name: Install eatmydata
if: steps.changes.outputs.unit_tests == 'true'
run: |
sudo apt-get install -y --no-install-recommends eatmydata

- name: Get dependencies
if: steps.changes.outputs.unit_tests == 'true'
env:
LD_PRELOAD: "libeatmydata.so"
run: |
export DEBIAN_FRONTEND="noninteractive"
sudo apt-get update

# Uninstall any previously installed MySQL first
# sudo systemctl stop apparmor
Expand All @@ -105,7 +116,7 @@ jobs:
sudo apt-get update
sudo DEBIAN_FRONTEND="noninteractive" apt-get install -y mysql-server mysql-client

sudo apt-get install -y make unzip g++ curl git wget ant openjdk-11-jdk eatmydata
sudo apt-get install -y make unzip g++ curl git wget ant openjdk-11-jdk

sudo service mysql stop
sudo bash -c "echo '/usr/sbin/mysqld { }' > /etc/apparmor.d/usr.sbin.mysqld" # https://bugs.launchpad.net/ubuntu/+source/mariadb-10.1/+bug/1806263
Expand All @@ -124,11 +135,15 @@ jobs:

- name: Run make tools
if: steps.changes.outputs.unit_tests == 'true'
env:
LD_PRELOAD: "libeatmydata.so"
run: |
make tools

- name: Setup launchable dependencies
if: github.event_name == 'pull_request' && github.event.pull_request.draft == 'false' && steps.changes.outputs.unit_tests == 'true' && github.base_ref == 'main'
env:
LD_PRELOAD: "libeatmydata.so"
run: |
# Get Launchable CLI installed. If you can, make it a part of the builder image to speed things up
pip3 install --user launchable~=1.0 > /dev/null
Expand All @@ -142,6 +157,8 @@ jobs:
- name: Run test
if: steps.changes.outputs.unit_tests == 'true'
timeout-minutes: 30
env:
LD_PRELOAD: "libeatmydata.so"
run: |
set -exo pipefail
# We set the VTDATAROOT to the /tmp folder to reduce the file path of mysql.sock file
Expand All @@ -154,8 +171,8 @@ jobs:
# We sometimes need to alter the behavior based on the platform we're
# testing, e.g. MySQL 5.7 vs 8.0.
export CI_DB_PLATFORM="mysql80"
eatmydata -- make unit_test | tee -a output.txt | go-junit-report -set-exit-code > report.xml

make unit_test | tee -a output.txt | go-junit-report -set-exit-code > report.xml

- name: Record test results in launchable if PR is not a draft
if: github.event_name == 'pull_request' && github.event.pull_request.draft == 'false' && steps.changes.outputs.unit_tests == 'true' && github.base_ref == 'main' && !cancelled()
Expand Down
25 changes: 21 additions & 4 deletions .github/workflows/unit_test_evalengine_mysql84.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,22 @@ jobs:
echo "set man-db/auto-update false" | sudo debconf-communicate
sudo dpkg-reconfigure man-db

- name: Update apt
if: steps.changes.outputs.unit_tests == 'true'
run: |
sudo apt-get update

- name: Install eatmydata
if: steps.changes.outputs.unit_tests == 'true'
run: |
sudo apt-get install -y --no-install-recommends eatmydata

- name: Get dependencies
if: steps.changes.outputs.unit_tests == 'true'
env:
LD_PRELOAD: "libeatmydata.so"
run: |
export DEBIAN_FRONTEND="noninteractive"
sudo apt-get update

# Uninstall any previously installed MySQL first
# sudo systemctl stop apparmor
Expand All @@ -105,7 +116,7 @@ jobs:
sudo apt-get update
sudo DEBIAN_FRONTEND="noninteractive" apt-get install -y mysql-server mysql-client

sudo apt-get install -y make unzip g++ curl git wget ant openjdk-11-jdk eatmydata
sudo apt-get install -y make unzip g++ curl git wget ant openjdk-11-jdk

sudo service mysql stop
sudo bash -c "echo '/usr/sbin/mysqld { }' > /etc/apparmor.d/usr.sbin.mysqld" # https://bugs.launchpad.net/ubuntu/+source/mariadb-10.1/+bug/1806263
Expand All @@ -124,11 +135,15 @@ jobs:

- name: Run make tools
if: steps.changes.outputs.unit_tests == 'true'
env:
LD_PRELOAD: "libeatmydata.so"
run: |
make tools

- name: Setup launchable dependencies
if: github.event_name == 'pull_request' && github.event.pull_request.draft == 'false' && steps.changes.outputs.unit_tests == 'true' && github.base_ref == 'main'
env:
LD_PRELOAD: "libeatmydata.so"
run: |
# Get Launchable CLI installed. If you can, make it a part of the builder image to speed things up
pip3 install --user launchable~=1.0 > /dev/null
Expand All @@ -142,6 +157,8 @@ jobs:
- name: Run test
if: steps.changes.outputs.unit_tests == 'true'
timeout-minutes: 30
env:
LD_PRELOAD: "libeatmydata.so"
run: |
set -exo pipefail
# We set the VTDATAROOT to the /tmp folder to reduce the file path of mysql.sock file
Expand All @@ -154,8 +171,8 @@ jobs:
# We sometimes need to alter the behavior based on the platform we're
# testing, e.g. MySQL 5.7 vs 8.0.
export CI_DB_PLATFORM="mysql84"
eatmydata -- make unit_test | tee -a output.txt | go-junit-report -set-exit-code > report.xml

make unit_test | tee -a output.txt | go-junit-report -set-exit-code > report.xml

- name: Record test results in launchable if PR is not a draft
if: github.event_name == 'pull_request' && github.event.pull_request.draft == 'false' && steps.changes.outputs.unit_tests == 'true' && github.base_ref == 'main' && !cancelled()
Expand Down
25 changes: 21 additions & 4 deletions .github/workflows/unit_test_mysql57.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,22 @@ jobs:
echo "set man-db/auto-update false" | sudo debconf-communicate
sudo dpkg-reconfigure man-db

- name: Update apt
if: steps.changes.outputs.unit_tests == 'true'
run: |
sudo apt-get update

- name: Install eatmydata
if: steps.changes.outputs.unit_tests == 'true'
run: |
sudo apt-get install -y --no-install-recommends eatmydata

- name: Get dependencies
if: steps.changes.outputs.unit_tests == 'true'
env:
LD_PRELOAD: "libeatmydata.so"
run: |
export DEBIAN_FRONTEND="noninteractive"
sudo apt-get update

# Uninstall any previously installed MySQL first
# sudo systemctl stop apparmor
Expand Down Expand Up @@ -115,7 +126,7 @@ jobs:
sudo dpkg -i libtinfo5_6.3-2ubuntu0.1_amd64.deb
sudo DEBIAN_FRONTEND="noninteractive" apt-get install -y mysql-client=5.7* mysql-community-server=5.7* mysql-server=5.7* libncurses6

sudo apt-get install -y make unzip g++ curl git wget ant openjdk-11-jdk eatmydata
sudo apt-get install -y make unzip g++ curl git wget ant openjdk-11-jdk

sudo service mysql stop
sudo bash -c "echo '/usr/sbin/mysqld { }' > /etc/apparmor.d/usr.sbin.mysqld" # https://bugs.launchpad.net/ubuntu/+source/mariadb-10.1/+bug/1806263
Expand All @@ -134,11 +145,15 @@ jobs:

- name: Run make tools
if: steps.changes.outputs.unit_tests == 'true'
env:
LD_PRELOAD: "libeatmydata.so"
run: |
make tools

- name: Setup launchable dependencies
if: github.event_name == 'pull_request' && github.event.pull_request.draft == 'false' && steps.changes.outputs.unit_tests == 'true' && github.base_ref == 'main'
env:
LD_PRELOAD: "libeatmydata.so"
run: |
# Get Launchable CLI installed. If you can, make it a part of the builder image to speed things up
pip3 install --user launchable~=1.0 > /dev/null
Expand All @@ -152,6 +167,8 @@ jobs:
- name: Run test
if: steps.changes.outputs.unit_tests == 'true'
timeout-minutes: 30
env:
LD_PRELOAD: "libeatmydata.so"
run: |
set -exo pipefail
# We set the VTDATAROOT to the /tmp folder to reduce the file path of mysql.sock file
Expand All @@ -164,8 +181,8 @@ jobs:
# We sometimes need to alter the behavior based on the platform we're
# testing, e.g. MySQL 5.7 vs 8.0.
export CI_DB_PLATFORM="mysql57"
eatmydata -- make unit_test | tee -a output.txt | go-junit-report -set-exit-code > report.xml

make unit_test | tee -a output.txt | go-junit-report -set-exit-code > report.xml

- name: Record test results in launchable if PR is not a draft
if: github.event_name == 'pull_request' && github.event.pull_request.draft == 'false' && steps.changes.outputs.unit_tests == 'true' && github.base_ref == 'main' && !cancelled()
Expand Down
25 changes: 21 additions & 4 deletions .github/workflows/unit_test_mysql80.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,22 @@ jobs:
echo "set man-db/auto-update false" | sudo debconf-communicate
sudo dpkg-reconfigure man-db

- name: Update apt
if: steps.changes.outputs.unit_tests == 'true'
run: |
sudo apt-get update

- name: Install eatmydata
if: steps.changes.outputs.unit_tests == 'true'
run: |
sudo apt-get install -y --no-install-recommends eatmydata

- name: Get dependencies
if: steps.changes.outputs.unit_tests == 'true'
env:
LD_PRELOAD: "libeatmydata.so"
run: |
export DEBIAN_FRONTEND="noninteractive"
sudo apt-get update

# Uninstall any previously installed MySQL first
# sudo systemctl stop apparmor
Expand All @@ -105,7 +116,7 @@ jobs:
sudo apt-get update
sudo DEBIAN_FRONTEND="noninteractive" apt-get install -y mysql-server mysql-client

sudo apt-get install -y make unzip g++ curl git wget ant openjdk-11-jdk eatmydata
sudo apt-get install -y make unzip g++ curl git wget ant openjdk-11-jdk

sudo service mysql stop
sudo bash -c "echo '/usr/sbin/mysqld { }' > /etc/apparmor.d/usr.sbin.mysqld" # https://bugs.launchpad.net/ubuntu/+source/mariadb-10.1/+bug/1806263
Expand All @@ -124,11 +135,15 @@ jobs:

- name: Run make tools
if: steps.changes.outputs.unit_tests == 'true'
env:
LD_PRELOAD: "libeatmydata.so"
run: |
make tools

- name: Setup launchable dependencies
if: github.event_name == 'pull_request' && github.event.pull_request.draft == 'false' && steps.changes.outputs.unit_tests == 'true' && github.base_ref == 'main'
env:
LD_PRELOAD: "libeatmydata.so"
run: |
# Get Launchable CLI installed. If you can, make it a part of the builder image to speed things up
pip3 install --user launchable~=1.0 > /dev/null
Expand All @@ -142,6 +157,8 @@ jobs:
- name: Run test
if: steps.changes.outputs.unit_tests == 'true'
timeout-minutes: 30
env:
LD_PRELOAD: "libeatmydata.so"
run: |
set -exo pipefail
# We set the VTDATAROOT to the /tmp folder to reduce the file path of mysql.sock file
Expand All @@ -154,8 +171,8 @@ jobs:
# We sometimes need to alter the behavior based on the platform we're
# testing, e.g. MySQL 5.7 vs 8.0.
export CI_DB_PLATFORM="mysql80"
eatmydata -- make unit_test | tee -a output.txt | go-junit-report -set-exit-code > report.xml

make unit_test | tee -a output.txt | go-junit-report -set-exit-code > report.xml

- name: Record test results in launchable if PR is not a draft
if: github.event_name == 'pull_request' && github.event.pull_request.draft == 'false' && steps.changes.outputs.unit_tests == 'true' && github.base_ref == 'main' && !cancelled()
Expand Down
Loading
Loading