-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Resolve Pinned-Dependencies CodeQL issues in CI
#18853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Resolve Pinned-Dependencies CodeQL issues in CI
#18853
Conversation
Signed-off-by: Tim Vaillancourt <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Pinned-Dependencies CodeQL issuesPinned-Dependencies CodeQL issues in CI
|
|
||
| func main() { | ||
| var err error | ||
| goJunitReportSHA, err = getRepoHeadSHA1(githubOrg, goJunitReportRepo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made goJunitReportSHA a global var, but I could make it a plain var and pass it into the generate* funcs. Let me know!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18853 +/- ##
==========================================
+ Coverage 69.70% 69.72% +0.02%
==========================================
Files 1607 1607
Lines 214608 214608
==========================================
+ Hits 149592 149643 +51
+ Misses 65016 64965 -51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This PR resolves roughly 100-200~ CodeQL alerts for non-pinned-dependencies in our CI files. Complaints for the same issue in
Dockerfiles can be addressed in a separate PRThe risk CodeQL is highlighting is slightly exaggerated because we (
vitessio) own the repo we are pullingHEADfrom. This PR still improves security and predictability (consistent builds) howeverRelated Issue(s)
Example CodeQL Issue: https://github.com/vitessio/vitess/security/code-scanning/3921
Checklist
Deployment Notes
AI Disclosure