feat: allow merging test reports via a glob pattern - #10700
Open
abhiaagarwal wants to merge 2 commits into
Open
Conversation
Signed-off-by: Abhi Agarwal <abhiaagarwal01@gmail.com>
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Abhi Agarwal <abhiaagarwal01@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #10699. This adds the functionality to use a glob pattern instead for
--merge-reportsCLI option. This is useful for merging coverage reports across multiple subdirectories in say, a monorepo that's not using vitest's projects option.Note that I'm not sure this is the correct architectural boundary; ideally, collection of files happens at the interface level before it's passed to
readBlobs, but I didn't want to do a massive refactor. So this is a bit hairy. I also wasn't sure whether to add a new command line argument like--globto make the usage explicit instead of overriding the string, but given both--includeand--excludeuseisDynamicPatternto runtime swap between them, I figured this was the idiomatic choice.Updates docs/docstrings and adds a single e2e test.