feat: support fake timers for node:timers and node:timers/promise - #10899
Draft
hi-ogawa wants to merge 3 commits into
Draft
feat: support fake timers for node:timers and node:timers/promise#10899hi-ogawa wants to merge 3 commits into
node:timers and node:timers/promise#10899hi-ogawa wants to merge 3 commits into
Conversation
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
node:timers and node:timers/promise
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
node:timers and node:timers/promisenode:timers and node:timers/promise
node:timers and node:timers/promisenode:timers and node:timers/promise
node:timers and node:timers/promisenode:timers and node:timers/promise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
node:timersornode:timers/promises#10871TODO
Apparently, the doc has never mentioned the mocking behavior for node builtin
node:timersmocking, so need to discuss whether this is intended. Also update doc accordingly.There were multiple issues with previous approach:
timersModule = __vitest_required__.timers(and async timer variant) runs during fake timer module scope and__vitest_required__wasn't setup yet at that point.__vitest_required__.timersis originallyimport timers from "node:timers"and this only patches default/cjs exports objects. In order to propagate the mocking to named importsimport { setTimeout } from "node:timers", we can use node'ssyncBuiltinESMExportsmodule util.This PR fixes them by patching fake-timers more and wire-up
syncBuiltinESMExportsfor normal runner and vm runner separately.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.