Skip to content

feat(ui): navigate explorer with keyboard - #11025

Draft
hi-ogawa wants to merge 4 commits into
vitest-dev:mainfrom
hi-ogawa:explorer-keyboard-navigation
Draft

feat(ui): navigate explorer with keyboard#11025
hi-ogawa wants to merge 4 commits into
vitest-dev:mainfrom
hi-ogawa:explorer-keyboard-navigation

Conversation

@hi-ogawa

@hi-ogawa hi-ogawa commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Description

AI one shot take. No idea if it's working nor how it's working.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

hi-ogawa and others added 2 commits August 21, 2026 15:05
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
@netlify

netlify Bot commented Aug 21, 2026

Copy link
Copy Markdown

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b1b4d72
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/6a87eb1fccb36b0008955d63
😎 Deploy Preview https://deploy-preview-11025--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

hi-ogawa and others added 2 commits August 21, 2026 15:11
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
@userquin

userquin commented Aug 21, 2026

Copy link
Copy Markdown
Member

The tree is a live tree.

This seems to be fine, but we may need to defer adding listeners and maybe adding aria-* attrs until the tree is fully loaded (this approach can be a problem in large projects):

  • we may have some bottleneck/memory leaks with the @click listeners (?)
  • until tree is not fully loaded we're forcing unnecessary re-layout of every explorer item: all aria-* changing every 100ms

can you click rerun all the tests using the old core project recording performance once all test finished on first run (~5000 tests with 3 projects)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants