Fix for the race condition in Tab channel#2
Open
vigneswaranm wants to merge 1 commit intovitkarpov:masterfrom
Open
Fix for the race condition in Tab channel#2vigneswaranm wants to merge 1 commit intovitkarpov:masterfrom
vigneswaranm wants to merge 1 commit intovitkarpov:masterfrom
Conversation
Owner
|
@vigneswaranm First of all, thank you for the contribution! 👍 You're the first one actually 😃 Do you use the library in production? |
vitkarpov
reviewed
Jul 7, 2018
Owner
vitkarpov
left a comment
vitkarpov
left a comment
There was a problem hiding this comment.
First glance, some comments.
Haven't understood the race condition yet, could you elaborate it on your example?
| * The below code solves the problem | ||
| */ | ||
| if (data.key === channelId) { | ||
| var data = JSON.parse(data.newValue) || {}; |
Owner
There was a problem hiding this comment.
What is a newValue here? 🤔 Do we actually have it in data?
| if (data.channelId === channelId) { | ||
| window.parent.postMessage(data.message, '*'); | ||
| window.localStorage.removeItem(channelId); | ||
| } |
Owner
There was a problem hiding this comment.
Maybe we could refactor this a little bit and move to a function (within another commit), so the diff could be more relevant?
Owner
|
@vigneswaranm ping, can you explain the issue, please? Didn't get the problem so far. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.