Open
Conversation
…'com.vanniktech:android-image-cropper:4.3.3'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate image cropper library
Details
com.theartofdev.edmodo:android-image-cropper:2.8.0withcom.vanniktech:android-image-cropper:4.3.3Changes
Updated relevant code to handle significant API differences between the libraries.
app/build.gradle: Replaced thecom.theartofdev.edmodo:android-image-cropperlibrary with thecom.vanniktech:android-image-cropperlibrary.build.gradleAdded Maven Central repo, as this is wherecom.vanniktech:android-image-cropperis hostedapp/src/main/java/se/whitchurch/nordict/CameraActivity.kt: Imported new classes from thecom.canhub.cropperlibrary and added a newcropImageactivity result launcher. [1] [2]app/src/main/java/se/whitchurch/nordict/CameraActivity.kt: Updated the image saving and cropping logic to use the newCropImageContractandCropImageOptions.app/src/main/java/se/whitchurch/nordict/CameraActivity.kt: Added error handling for camera use case binding and ensured permissions results are handled correctly.app/src/main/AndroidManifest.xml: Updated the activity name for the image cropper to use the new library.app/src/main/res/layout/activity_camera.xml: Replaced the oldCropImageViewwith the new one from thecom.canhub.cropperlibrary.