trigger add event on add method in w2grid.js #2623
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitmalina
requested changes
Apr 7, 2025
| @@ -498,6 +498,7 @@ class w2grid extends w2base { | |||
| } else { | |||
| this.refresh() | |||
| } | |||
| this.trigger("add", {target: this.name}) | |||
There was a problem hiding this comment.
I think it would be useful to pass on record and first variables with the event, as those are arguments in the functio. Also, add spacing after { and before }
Also, I noticed that there is already an add event (search the code) and it is when add button is clicked, so event name should be addRecords,
Also, you should have event's before and after loop. See how other events are triggered, with edata.finish(). Event should be cancellable too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... in relation with issue #2622