w2grid.js: If sortMode callback is defined, let it make all decisions#2654
Open
pfalcon wants to merge 1 commit intovitmalina:masterfrom
Open
w2grid.js: If sortMode callback is defined, let it make all decisions#2654pfalcon wants to merge 1 commit intovitmalina:masterfrom
pfalcon wants to merge 1 commit intovitmalina:masterfrom
Conversation
Previously, this comparison callback was called too late, after applying various adhoc conversions. Chances, they wouldn't work as user want, only leading to confusion. So, as long as the comparison callback is defined, call it as soon, not as late, as possible. This includes letting it decide how null values are sorted, instead of hardcoding a particular behavior. Calling ASAP and skipping all conversions also saves CPU cycles in users' browsers.
Author
|
Proposed fix for #2653 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, this comparison callback was called too late, after applying various adhoc conversions. Chances, they wouldn't work as user want, only leading to confusion. So, as long as the comparison callback is defined, call it as soon, not as late, as possible. This includes letting it decide how null values are sorted, instead of hardcoding a particular behavior. Calling ASAP and skipping all conversions also saves CPU cycles in users' browsers.