✨ feat(android): wire sideload import to library-mirror push#64
Merged
Conversation
After Bundle 3 landed A-3 (sideload) and A-4 (library-mirror push job) in parallel branches, the integration between them was deliberately deferred: A-3 exposed an `onSuccessfulImport` hook; A-4 exposed `LibraryMirrorPushScheduler.enqueueAfterLibraryChange`. Both pieces are on main now, so wire them up: a freshly-imported book triggers an expedited library-mirror push instead of waiting for the next periodic run. The scheduler coalesces, so this is safe alongside the periodic worker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 0 cross-bundle wire-up follow-up.
A-3 (sideload pipeline, in Phase 0 bundle 3) exposed an
onSuccessfulImporthook onSideloadImporter. A-4 (WorkManager library-mirror push, also in bundle 3) exposedLibraryMirrorPushScheduler.enqueueAfterLibraryChange(context)as the entry point for an out-of-band push. They were intentionally not connected in the bundle PR so the diff stayed close to the constituent PRs.Now that both are on
main, wire them: a freshly imported book triggers an expedited library-mirror push instead of waiting for the next periodic run.Diff
One file, six lines added.
The scheduler coalesces concurrent enqueues, so this is safe alongside the periodic worker. Existing
onSuccessfulImportactions (sync-cursor reset + expedited sync enqueue) are preserved.Verification
scripts/dgradle :app:testDebugUnitTest :app:assembleDebug— BUILD SUCCESSFUL.