fix: Mark discount on cart root node as used too#175
Merged
sveneberth merged 1 commit intoviur-framework:mainfrom Jan 16, 2026
Merged
fix: Mark discount on cart root node as used too#175sveneberth merged 1 commit intoviur-framework:mainfrom
sveneberth merged 1 commit intoviur-framework:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request resolves an issue where discounts applied to the root node of a cart were not considered in the discount handling process. It ensures that all discounts, including those on the cart's root node, are correctly tracked and marked as used.
Key Changes
Add Root Node to Discount Collection:
get_discounts_from_cartmethod now explicitly adds the cart's root node to the list of nodes, ensuring discounts on the root node are correctly included:Ensure Discount Usage is Updated:
mark_discount_usedmethod is updated to handleorder_skelinstances properly. It tracks and increasesquantity_usedfor discounts associated with an ordered cart.Impact
These changes ensure that all discounts, including those applied at the root level, are tracked and managed accurately. This fixes inconsistencies in discount processing and improves overall reliability of the cart system.