Set cache-control headers for file uploads to align with DAM policy #3820
Conversation
| @@ -74,6 +74,7 @@ export function createFileUploadsDownloadController(options: { public: boolean } | |||
| "content-type": file.mimetype, | |||
| "last-modified": file.updatedAt?.toUTCString(), | |||
| "content-length": file.size, | |||
| "cache-control": options.public ? "max-age=86400, public" : "max-age=31536000, private", // same as DAM | |||
There was a problem hiding this comment.
The generated download URLs have a 1 h timeout. Shouldn't this be reflected here?
There was a problem hiding this comment.
ah, I didn't see that. So one hour might also be wrong as the URL might be called anytime from hash creation up to the lifetime.
What do you suggest?
There was a problem hiding this comment.
Options:
- Calculate the remaining time and set it as max-age for both
- Set no-store (like we did for download folders)
- Set private and allow infinite caching
I'm not sure which option is the best, but all are fine probably.
There was a problem hiding this comment.
If this should be cached by CDN: 1️⃣
if we don't care about cdn caching: 2️⃣
As createDownloadUrl create a new, unique url for every usage, CDN cache can't be used anyway, It would just fill up with "garbage". For that reason 2️⃣ (or 3️⃣ is also ok)
(and the same should be applied to image function below)
No description provided.