Add admin not found page #3870
Add admin not found page #3870
Conversation
|
@manuelblum I intend to change MasterMenuRoutes to always redirect to the first match if a route doesn't exist here. This would conflict with your implementation. Should I revert my change? Do we need a not found page? |
|
@johnnyomair from an UX perspective, i would prefer having a Not Found page, instead of an redirect to a first route match. I also thing we discussed this with UX already. Maybe should rediscuss the desired behaviour one more time with ux at least we have now both solutions implemented. |
| @@ -33,18 +34,24 @@ export function useRoutePropsFromMasterMenuData(items: MasterMenuData): RoutePro | |||
|
|
|||
| export interface MasterMenuRoutesProps { | |||
| menu: MasterMenuData; | |||
| notFoundPage?: ReactNode; | |||
There was a problem hiding this comment.
What do you think about using fallback instead? This could also be used to display an access denied page.
There was a problem hiding this comment.
what do you mean with fallback? Just renaming the prop?
There was a problem hiding this comment.
We already have https://github.com/vivid-planet/comet/blob/next/packages/admin/cms-admin/src/common/header/about/CometDigitalExperienceLogo.tsx, isn't this the same?
There was a problem hiding this comment.
it is different see:
CometDxpLogo:
CometDigitalExperienceLogo:
There was a problem hiding this comment.
@manuelblum could we change the existing CometDigitalExperience component so support both logos? I think it could be confusing if we have two components with a similar name.
Description
Previously, when navigating to a non-existent admin route or a page the user doesn’t have permission to access, the app would render a blank white screen. This PR improves the user experience by introducing a fallback route that displays a “Not Found” page instead.
Additionally, projects can now provide a custom “Not Found” page by setting the
notFoundPageprop on theMasterMenuRoutescomponent.Screenshots/screencasts
Further information