Admin: Add new Breadcrumbs component
#4936
Open
+143
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliawegmayr
force-pushed
the
breadcrumbs-desktop
branch
2 times, most recently
from
95b432e to
dcbef71
Compare
juliawegmayr
force-pushed
the
breadcrumbs-desktop
branch
from
dcbef71 to
a61622d
Compare
juliawegmayr
force-pushed
the
breadcrumbs-desktop
branch
from
a61622d to
8ce54ee
Compare
juliawegmayr
changed the title
Breadcrumbs component
jamesricky
reviewed
Dec 16, 2025
jamesricky
reviewed
Dec 16, 2025
jamesricky
reviewed
Dec 19, 2025
jamesricky
reviewed
Dec 19, 2025
Co-authored-by: Ricky James Smith <[email protected]>
Co-authored-by: Ricky James Smith <[email protected]>
jamesricky
previously approved these changes
Dec 22, 2025
johnnyomair
reviewed
Dec 22, 2025
|
|
||
| type BreadcrumbsClassKey = "root" | "breadcrumbsItem" | "separator"; | ||
|
|
||
| export interface BreadcrumbsItem { |
Collaborator
There was a problem hiding this comment.
Naming: instead of BreadcrumbsItem we could also go with Breadcrumb, but I'm not sure what's better.
| interface BreadcrumbsProps | ||
| extends ThemedComponentBaseProps<{ | ||
| root: "div"; | ||
| breadcrumbsItem: typeof Typography; |
Collaborator
There was a problem hiding this comment.
Naming: why add the "breadcrumbs" prefix here, but not for the other slots?
Contributor
Author
There was a problem hiding this comment.
I changed it to item instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new
Breadcrumbcomponent is added, that should be used for rendering breadcrumbs in the admin (instead of StackBreadcrumbs and ToolbarBreadcrumbs).In this PR the component is added and styled for desktop only.
Acceptance criteria
Screenshots/screencasts
Open TODOs/questions
Further information