Remove as cast #4962
Remove as cast #4962
Conversation
| }; | ||
|
|
||
| function ProductsGridToolbar({ exportApi, selectionModel }: ProductsGridToolbarProps) { | ||
| const ProductsGridToolbar: React.JSXElementConstructor<GridSlotProps["toolbar"] & ProductsGridToolbarProps> = ({ |
There was a problem hiding this comment.
How is this explicit type definition here better than the as cast? 🤔
There was a problem hiding this comment.
As far as I know as does disable any check. this kind of definition provides more type-safety. If the function is defined differently a typescript error is thrown for initializing the data-grid.
And as mentioned in the description in my application I needed to change the additional props to optional. I don't know why this wasn't necessary here.
There was a problem hiding this comment.
There was a problem hiding this comment.
Module augmentation solution worked in this file, but resulted in issues in an other file. also I didn't found a solution for local module augmentation only, so augmented fields are also "available" in other grid-components.
There was a problem hiding this comment.
module augmentation is always global, I was thinking about something like that:
type ToolbarProps = PropsFromSlot<GridSlots['toolbar']> & ProductsGridToolbarProps;
Description
Idea to remove as cast in data-grid. Note: in my application code I had to make all props optional for typescript to stop complaining