API Generator: Add support for soft delete by setting deletedAt in delete mutation #4969
+65
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lete mutation Note: The filter to exclude deleted entries by default has to be added manually to the entity, api-generator can't do that.
johnnyomair
changed the title
johnnyomair
reviewed
Dec 22, 2025
Collaborator
johnnyomair
left a comment
johnnyomair
left a comment
There was a problem hiding this comment.
How would soft deletes work with relations? Would the relations still be queryable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is for implementing a soft delete with unchanged api, no possibility to query deleted entries.
This changes the delete mutation to set deletedAt to current date instead of calling remove()
The filter to exclude deleted entries by default has to be added manually to the entity, API Generator can't do that.
Possibly breaking: we might consider this breaking as it changes behavior when a deletedAt column exists. But it is needed in a project...