Fix warnings #357
Open
Fix warnings #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes 2 comparisons between different signedness integers. The first one is the signal type defined in block structure. In C, signal numbers are defined as int. This commit fixes the definition in block.h. The second one is a comparison between and int and an enum. The comparison requires the enum to be caseted in int. The third one is the comparison between the result of snprintf()(ie. int) and a sizeof variable (ie. size_t). This comparison requires the int to be casted in unsigned, since the if statement ensures that the value is not negative. This commit casts the int variable in size_t when it is compared to a size_t.
The variable err is unused in functions block_send and block_setup.
This fixes several unused parameters using the common method: (void)the_unused_parameter;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes warnings reported by
make CFLAGS+=-Wall -Wextra