Accept EOF as well as newline to complete line read #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently a line isn't read if any error is reached, including EAGAIN, which indicates you've reached the end of a file descriptor. This commit allows EAGAIN to terminate a line if anything else has been read from that fd. If nothing else has been read, it's either non-existent or empty, which makes sense to error instead.
|
You shall modify |
Closed
dllud
pushed a commit
to dllud/i3blocks
that referenced
this pull request
Jan 12, 2024
eyedropper: add support for Sway, and for copying to the clipboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #393 and #403.
Currently a line isn't read if any error is reached, including EAGAIN,
which indicates you've reached the end of a file descriptor.
This commit allows EAGAIN to terminate a line if anything else has been
read from that fd. If nothing else has been read, it's either
non-existent or empty, which makes sense to error instead.