Skip to content

Add Awesome Vivliostyle reference page#14

Merged
ogwata merged 8 commits intomainfrom
add-awesome-vivliostyle
Feb 27, 2026
Merged

Add Awesome Vivliostyle reference page#14
ogwata merged 8 commits intomainfrom
add-awesome-vivliostyle

Conversation

@ogwata
Copy link
Copy Markdown
Member

@ogwata ogwata commented Feb 26, 2026

Summary

  • add Awesome Vivliostyle docs from submodule and wire into reference navigation (JA/EN)
  • insert TOC heading for the Awesome page and fix the Print CSS sites TOC label/link
  • update the awesome-vivliostyle submodule reference
  • add workspace settings to stabilize encoding/terminal font

Testing

  • npm run dev

@ogwata ogwata requested a review from Copilot February 26, 2026 14:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an “Awesome Vivliostyle” reference page sourced from a Git submodule and integrates it into the JA/EN reference navigation and TOC handling.

Changes:

  • Add Awesome Vivliostyle content collections (JA/EN) and route wiring for /reference/awesome-vivliostyle/
  • Update reference navigation/ordering and adjust TOC rendering for the Awesome page
  • Update/add submodule + repo/editor settings related to the new docs source

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
submodules/awesome-vivliostyle Bumps the submodule commit used as the docs source.
src/pages/ja/reference/index.astro Adds Awesome Vivliostyle to the JA reference index navigation.
src/pages/ja/reference/[...slug].astro Generates static path + sidebar entry + TOC UI for the Awesome page (JA).
src/pages/en/reference/index.astro Adds Awesome Vivliostyle to the EN reference index navigation.
src/pages/en/reference/[...slug].astro Generates static path + sidebar entry + TOC UI for the Awesome page (EN).
src/loaders/vfm-loader.ts Adds Awesome-specific TOC label/anchor normalization during TOC HTML extraction.
src/layouts/DocsLayout.astro Adds Awesome Vivliostyle to the shared reference nav links.
src/content.config.ts Registers new content collections for awesome-vivliostyle EN/JA via vfmLoader.
content/ja/reference/index.md Adds Awesome Vivliostyle to the JA reference landing page list.
content/en/reference/index.md Adds Awesome Vivliostyle to the EN reference landing page list.
.vscode/settings.json Adds workspace-level editor/terminal settings (encoding + fonts).
.gitmodules Adds the awesome-vivliostyle submodule configuration.
Comments suppressed due to low confidence (2)

src/pages/ja/reference/[...slug].astro:1

  • This “awesome doc normalization” logic is now duplicated across both JA and EN [...slug].astro pages (including translation-ID set creation and the extra paths.push). Consider extracting a small shared helper (e.g., in src/lib/reference.ts) to build awesomeReferenceDoc, referenceDocsAll, and translation presence flags to reduce drift and simplify future updates.
    src/pages/ja/reference/[...slug].astro:1
  • This “awesome doc normalization” logic is now duplicated across both JA and EN [...slug].astro pages (including translation-ID set creation and the extra paths.push). Consider extracting a small shared helper (e.g., in src/lib/reference.ts) to build awesomeReferenceDoc, referenceDocsAll, and translation presence flags to reduce drift and simplify future updates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/loaders/vfm-loader.ts
Comment thread .vscode/settings.json Outdated
Comment thread src/loaders/vfm-loader.ts Outdated
@MurakamiShinyu
Copy link
Copy Markdown
Member

「Awesome Vivliostyle」の目次は「サポートする CSS 機能」と同様にサイドメニューにほしいです。それから見出しの階層がわかるように。

@ogwata
Copy link
Copy Markdown
Member Author

ogwata commented Feb 27, 2026

「Awesome Vivliostyle」の目次は「サポートする CSS 機能」と同様にサイドメニューにほしいです。それから見出しの階層がわかるように。

ありがとうございます。1d39730で修正しました。

@MurakamiShinyu
Copy link
Copy Markdown
Member

Awesome Vivliostyleの目次内容がサイドメニューに移動しましたが、"Table of Contents" という見出しだけ残った状態になってるのが変です。

@ogwata
Copy link
Copy Markdown
Member Author

ogwata commented Feb 27, 2026

Awesome Vivliostyleの目次内容がサイドメニューに移動しましたが、"Table of Contents" という見出しだけ残った状態になってるのが変です。

失礼しました。e207a54で対応しました。

@ogwata ogwata merged commit 6681636 into main Feb 27, 2026
3 checks passed
@ogwata ogwata deleted the add-awesome-vivliostyle branch February 27, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants