Conversation
There was a problem hiding this comment.
Pull request overview
Adds an “Awesome Vivliostyle” reference page sourced from a Git submodule and integrates it into the JA/EN reference navigation and TOC handling.
Changes:
- Add Awesome Vivliostyle content collections (JA/EN) and route wiring for
/reference/awesome-vivliostyle/ - Update reference navigation/ordering and adjust TOC rendering for the Awesome page
- Update/add submodule + repo/editor settings related to the new docs source
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| submodules/awesome-vivliostyle | Bumps the submodule commit used as the docs source. |
| src/pages/ja/reference/index.astro | Adds Awesome Vivliostyle to the JA reference index navigation. |
| src/pages/ja/reference/[...slug].astro | Generates static path + sidebar entry + TOC UI for the Awesome page (JA). |
| src/pages/en/reference/index.astro | Adds Awesome Vivliostyle to the EN reference index navigation. |
| src/pages/en/reference/[...slug].astro | Generates static path + sidebar entry + TOC UI for the Awesome page (EN). |
| src/loaders/vfm-loader.ts | Adds Awesome-specific TOC label/anchor normalization during TOC HTML extraction. |
| src/layouts/DocsLayout.astro | Adds Awesome Vivliostyle to the shared reference nav links. |
| src/content.config.ts | Registers new content collections for awesome-vivliostyle EN/JA via vfmLoader. |
| content/ja/reference/index.md | Adds Awesome Vivliostyle to the JA reference landing page list. |
| content/en/reference/index.md | Adds Awesome Vivliostyle to the EN reference landing page list. |
| .vscode/settings.json | Adds workspace-level editor/terminal settings (encoding + fonts). |
| .gitmodules | Adds the awesome-vivliostyle submodule configuration. |
Comments suppressed due to low confidence (2)
src/pages/ja/reference/[...slug].astro:1
- This “awesome doc normalization” logic is now duplicated across both JA and EN
[...slug].astropages (including translation-ID set creation and the extrapaths.push). Consider extracting a small shared helper (e.g., insrc/lib/reference.ts) to buildawesomeReferenceDoc,referenceDocsAll, and translation presence flags to reduce drift and simplify future updates.
src/pages/ja/reference/[...slug].astro:1 - This “awesome doc normalization” logic is now duplicated across both JA and EN
[...slug].astropages (including translation-ID set creation and the extrapaths.push). Consider extracting a small shared helper (e.g., insrc/lib/reference.ts) to buildawesomeReferenceDoc,referenceDocsAll, and translation presence flags to reduce drift and simplify future updates.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
「Awesome Vivliostyle」の目次は「サポートする CSS 機能」と同様にサイドメニューにほしいです。それから見出しの階層がわかるように。 |
ありがとうございます。1d39730で修正しました。 |
|
Awesome Vivliostyleの目次内容がサイドメニューに移動しましたが、"Table of Contents" という見出しだけ残った状態になってるのが変です。 |
失礼しました。e207a54で対応しました。 |
Summary
Testing