Conversation
This reverts commit 1ebeeb5.
There was a problem hiding this comment.
Pull request overview
This pull request reverts the "feat: Template" feature introduced in #22. The revert simplifies the codebase by removing template serving functionality, simplifying the store architecture from complex class-based proxies to plain valtio proxies, and removing new-project UI flows and related components.
Changes:
- Downgraded dependency versions (vite 6.3.5→6.2.1, vitest 3.2.4→3.2.3, yjs 13.6.29→13.6.24, etc.)
- Removed template directory serving logic and tar dependency from vite config
- Deleted template directories (minimal, basic templates)
- Refactored store architecture from class-based proxies to plain valtio objects
- Removed new-project route and related UI components (radio, popover, label, command, stacked-radio, loading-ui)
- Simplified pane content structure with embedded title functions
- Removed bundle configuration stubs
Reviewed changes
Copilot reviewed 95 out of 99 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Downgraded dependency versions including vite, vitest, yjs, vivliostyle/cli |
| packages/viola/vite.config.ts | Removed 53-line template serving plugin and tar import |
| packages/viola/templates/ | Deleted minimal and basic template directories |
| packages/viola/src/stores/ | Refactored from class-based proxies to plain valtio objects |
| packages/viola/src/routes/ | Changed routes from beforeLoad to onEnter hooks; removed new-project route |
| packages/viola/src/components/ | Simplified pane structure with embedded title functions; removed UI components |
| packages/ui/ | Removed loading prop from Button component |
| package.json | Removed vite@6.3.5.patch from patchedDependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| delete $sandbox.files[ | ||
| join($sandbox.vivliostyleConfig.entryContext || '', file.filename) | ||
| ]; |
There was a problem hiding this comment.
The file.filename already includes the entryContext (see setup-project.ts line 46 where it's constructed as join(entryContext, entry.path)). Joining it again with entryContext here creates an incorrect file path with duplicated directory levels. Should use file.filename directly without joining entryContext again.
| $sandbox.files[ | ||
| join($sandbox.vivliostyleConfig.entryContext || '', file.filename) | ||
| ] = ref(new Blob([markdown], { type: 'text/markdown' })); |
There was a problem hiding this comment.
The file.filename already includes the entryContext when it was stored (see setup-project.ts line 46). Joining it again with entryContext here creates an incorrect file path with duplicated directory levels. Should use file.filename directly without joining entryContext again.
Reverts #22