Upgrade jquery.scrollTo and include as webjar - #524
Merged
Conversation
chenejac
approved these changes
Jun 9, 2026
chenejac
left a comment
chenejac
left a comment
Contributor
There was a problem hiding this comment.
@brianjlowe works for me. I have tested this at the example of listing research works (articles), before application of this fix it did not work, and after using your PR it is fixed.
The code looks fine.
litvinovg
self-requested a review
June 10, 2026 15:03
litvinovg
approved these changes
Jun 10, 2026
litvinovg
left a comment
litvinovg
left a comment
Member
There was a problem hiding this comment.
Works fine. Fixes the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VIVO-4148: (please link to issue)
What does this pull request do?
Fixes the bug described in VIVO-4148 caused by outdated jquery.scrollTo plugin. Upgrades jquery.scrollTo to the most recent webjar release.
How should this be tested?
Follow the steps to reproduce listed in the linked issue. After applying the PR, you will now be able to scroll to the bottom of the VClass browse page, click the link for the second page of results, and have it update properly.
Interested parties
@VIVO-project/vivo-committers
Reviewers' expertise
Please add any new expertise in the list which might be needed for reviewing your PR or remove any of the listed if it is not needed.
Candidates for reviewing this PR should have some of the following expertises:
[No special expertise needed.]
Reviewers' report template
Please update the following template which should be used by reviewers.
General comment
A reviewer should provide here comments and suggestions for requested changes if any.
Testing
A reviewer should briefly describe here how it was tested
Code reviewing
A reviewer should briefly describe here which part was code reviewed