Skip to content

feat: update title on note content change #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 30, 2024
Merged

feat: update title on note content change #143

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
edaf53f
feat: update title on note content change
anig1scur Oct 23, 2024
fbe8af5
chore: update listen & add ellipsis
anig1scur Oct 23, 2024
4506070
chore: bind note title to window
anig1scur Oct 23, 2024
d3fc6f0
chore: Untitled Note for empty
anig1scur Oct 24, 2024
ee60b6f
chore: gettext
anig1scur Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ export interface INote {
v: 1;
uuid: string;
content: string;
title: string;
style: Style;
tags: ITag[];
modified: Date;
Expand Down Expand Up @@ -151,6 +152,7 @@ export class Note extends GObject.Object {
v: 1;
uuid: string;
content: string;
title: string;
style: Style;
tag_list: Gio.ListStore<Tag>;
modified: GLib.DateTime;
Expand Down Expand Up @@ -201,6 +203,7 @@ export class Note extends GObject.Object {
this.v = note.v;
this.uuid = note.uuid;
this.content = note.content;
this.title = note.title;
this.style = note.style;
this.tag_list = Gio.ListStore.new(Tag.$gtype) as Gio.ListStore<Tag>;
this.tags = note.tags;
Expand All @@ -211,13 +214,31 @@ export class Note extends GObject.Object {
this.width = note.width;
this.height = note.height;
this.open = note.open ?? false;

// @ts-expect-error incorrect types
this.bind_property_full(
"content",
this,
"title",
GObject.BindingFlags.SYNC_CREATE,
(_, content) => {
if (!content) return [true, ""];
let title = content.split("\n")[0].slice(0, 20);
if (title.length != content.length) title += "…";
return [true, title];
},
null
);


}

static generate() {
return new this({
v: 1,
uuid: GLib.uuid_string_random(),
content: "",
title: "",
style: SETTINGS.DEFAULT_STYLE,
tags: [],
modified: new Date(),
Expand All @@ -232,6 +253,7 @@ export class Note extends GObject.Object {
v: this.v,
uuid: this.uuid,
content: this.content,
title: this.title,
style: this.style,
tags: this.tags.map((tag) => ({
name: tag.name,
Expand All @@ -250,6 +272,7 @@ export class Note extends GObject.Object {
v: this.v,
uuid: this.uuid,
content: this.content,
title: this.title,
style: this.style,
tags: this.tags,
modified: this.modified_date,
Expand All @@ -270,6 +293,8 @@ export class Note extends GObject.Object {
// deno-fmt-ignore
content: GObject.ParamSpec.string("content", "Content", "Content of the note", GObject.ParamFlags.READWRITE, ""),
// deno-fmt-ignore
title: GObject.ParamSpec.string("title", "Title", "Title of the note", GObject.ParamFlags.READWRITE, ""),
// deno-fmt-ignore
style: GObject.ParamSpec.int("style", "Style", "Style of the note", GObject.ParamFlags.READWRITE, 0, 100, 0),
// deno-fmt-ignore
tag_list: this.tag_list_pspec,
Expand Down
14 changes: 14 additions & 0 deletions src/window.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,20 @@ export class Window extends Adw.ApplicationWindow {
this.default_width = note.width;
this.default_height = note.height;

this.note.bind_property_full(
"title",
this,
"title",
GObject.BindingFlags.SYNC_CREATE,
(_, title) => {
if (!title) {
return [true, "Untitled Note"];
Copy link
Owner

@vixalien vixalien Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like "Sticky Note" may be better here.

Also, wrap the string in a _("string") so that it may get picked up by gettext (the translation infrastructure).

Suggested change
return [true, "Untitled Note"];
return [true, _("Sticky Note")];

Copy link
Contributor Author

@anig1scur anig1scur Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done !

}
return [true, title];
},
null
);

this.connect("close-request", () => {
if (this.deleted) return;

Expand Down
Loading