fix: resolve Windows compilation warnings (MSVC)

Signed-off-by: Vincent Jardin <vjardin@free.fr>

Author: vjardin

meson.build

@@ -60,6 +60,8 @@ endif
 if host_machine.system() == 'windows'
   # Windows requires SetupAPI for USB device detection
   deps += cc.find_library('setupapi')
+  # Suppress MSVC warnings about deprecated CRT functions (fopen, sscanf, getenv, etc.)
+  add_project_arguments('-D_CRT_SECURE_NO_WARNINGS', language : 'c')
 elif host_machine.system() == 'darwin'
   # macOS requires IOKit and CoreFoundation for USB device detection
   deps += dependency('appleframeworks', modules : ['IOKit', 'CoreFoundation'])

src/formats.c

@@ -121,7 +121,7 @@ bin_parse(const char *filename, parsed_file_t *out) {
     return -1;
   }
 
-  ssize_t n = read(fd, out->data, out->size);
+  ssize_t n = read(fd, out->data, (unsigned int)out->size);
   close(fd);
 
   if (n < 0 || (size_t)n != out->size) {
@@ -186,31 +186,31 @@ ihex_parse(const char *filename, parsed_file_t *out) {
       goto fail;
     }
 
-    uint16_t addr = (addr_hi << 8) | addr_lo;
+    uint16_t addr = (uint16_t)((addr_hi << 8) | addr_lo);
     size_t expected_len = 8 + byte_count * 2 + 2;
     if (len < expected_len) {
       warnx("%s:%d: line too short for byte count", filename, line_num);
       goto fail;
     }
 
-    uint8_t checksum = byte_count + addr_hi + addr_lo + rec_type;
+    uint8_t checksum = (uint8_t)(byte_count + addr_hi + addr_lo + rec_type);
     uint8_t data[256];
     for (int i = 0; i < byte_count; i++) {
       int b = hex_byte(p + 8 + i * 2);
       if (b < 0) {
         warnx("%s:%d: invalid hex digits in data", filename, line_num);
         goto fail;
       }
-      data[i] = b;
-      checksum += b;
+      data[i] = (uint8_t)b;
+      checksum = (uint8_t)(checksum + b);
     }
 
     int file_checksum = hex_byte(p + 8 + byte_count * 2);
     if (file_checksum < 0) {
       warnx("%s:%d: invalid checksum hex", filename, line_num);
       goto fail;
     }
-    checksum += file_checksum;
+    checksum = (uint8_t)(checksum + file_checksum);
     if (checksum != 0) {
       warnx("%s:%d: checksum mismatch", filename, line_num);
       goto fail;
@@ -377,16 +377,16 @@ srec_parse(const char *filename, parsed_file_t *out) {
       goto fail;
     }
 
-    uint8_t checksum = byte_count;
+    uint8_t checksum = (uint8_t)byte_count;
     uint32_t addr = 0;
     for (int i = 0; i < addr_bytes; i++) {
       int b = hex_byte(p + 2 + i * 2);
       if (b < 0) {
         warnx("%s:%d: invalid address hex", filename, line_num);
         goto fail;
       }
-      addr = (addr << 8) | b;
-      checksum += b;
+      addr = (addr << 8) | (uint32_t)b;
+      checksum = (uint8_t)(checksum + b);
     }
 
     int data_bytes = byte_count - addr_bytes - 1;
@@ -397,16 +397,16 @@ srec_parse(const char *filename, parsed_file_t *out) {
         warnx("%s:%d: invalid data hex", filename, line_num);
         goto fail;
       }
-      data[i] = b;
-      checksum += b;
+      data[i] = (uint8_t)b;
+      checksum = (uint8_t)(checksum + b);
     }
 
     int file_checksum = hex_byte(p + 2 + addr_bytes * 2 + data_bytes * 2);
     if (file_checksum < 0) {
       warnx("%s:%d: invalid checksum hex", filename, line_num);
       goto fail;
     }
-    checksum += file_checksum;
+    checksum = (uint8_t)(checksum + file_checksum);
     if (checksum != 0xFF) {
       warnx("%s:%d: checksum mismatch", filename, line_num);
       goto fail;
@@ -517,7 +517,7 @@ ihex_write(const char *filename, const uint8_t *data, size_t size, uint32_t addr
     /* Emit extended linear address record if needed (type 04) */
     uint32_t ext_addr = line_addr >> 16;
     if (ext_addr != current_ext_addr) {
-      uint8_t sum = 0x02 + 0x00 + 0x00 + 0x04 + (ext_addr >> 8) + (ext_addr & 0xFF);
+      uint8_t sum = (uint8_t)(0x02 + 0x00 + 0x00 + 0x04 + (ext_addr >> 8) + (ext_addr & 0xFF));
       fprintf(fp, ":02000004%04X%02X\n", ext_addr, (uint8_t)(~sum + 1));
       current_ext_addr = ext_addr;
     }

src/main.c

@@ -806,8 +806,8 @@ main(int argc, char *argv[]) {
     if (best > 9600) {
       if (ra_set_baudrate(&dev, best) == 0) {
         /* Verify communication works at new rate */
-        uint32_t verify;
-        if (ra_get_rmb(&dev, &verify) < 0) {
+        uint32_t rmb_check;
+        if (ra_get_rmb(&dev, &rmb_check) < 0) {
           ra_close(&dev);
           errx(EXIT_FAILURE,
               "communication failed at %u bps, reset board and use -b 115200 or lower",

src/radfu.c

@@ -1035,8 +1035,8 @@ ra_verify(
       }
     }
 
-    file_offset += cmp_len;
-    current_addr += chunk_len;
+    file_offset += (uint32_t)cmp_len;
+    current_addr += (uint32_t)chunk_len;
 
     /* Send ACK for all packets except the last one (per spec 6.20.3) */
     if (i < nr_packets) {
@@ -1114,7 +1114,7 @@ ra_blank_check(ra_device_t *dev, uint32_t start, uint32_t size) {
       }
     }
 
-    current_addr += chunk_len;
+    current_addr += (uint32_t)chunk_len;
 
     /* Send ACK for all packets except the last one (per spec 6.20.3) */
     if (i < nr_packets) {

src/rapacker.c

@@ -52,7 +52,7 @@ ra_strdesc(uint8_t code) {
 
 uint8_t
 ra_calc_sum(uint8_t cmd, const uint8_t *data, size_t len) {
-  uint16_t pkt_len = len + 1;
+  uint16_t pkt_len = (uint16_t)(len + 1);
   uint8_t lnh = (pkt_len >> 8) & 0xFF;
   uint8_t lnl = pkt_len & 0xFF;
   uint32_t sum = lnh + lnl + cmd;
@@ -77,7 +77,7 @@ ra_pack_pkt(uint8_t *buf, size_t buflen, uint8_t cmd, const uint8_t *data, size_
     return -1;
   }
 
-  uint16_t data_len = len + 1; /* includes CMD in length */
+  uint16_t data_len = (uint16_t)(len + 1); /* includes CMD in length */
   uint8_t lnh = (data_len >> 8) & 0xFF;
   uint8_t lnl = data_len & 0xFF;
   uint8_t sum = ra_calc_sum(cmd, data, len);