Skip to content

Conversation

@bkmgit
Copy link
Contributor

@bkmgit bkmgit commented Jul 9, 2025

Summary:

Test on Fedora linux and make RPM packages for Fedora linux supported versions.

Related Issue(s):

Closes #2462

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All linting checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@bkmgit
Copy link
Contributor Author

bkmgit commented Jul 9, 2025

If this will be useful, can add a build_rpm.py script within the utils directory.

@vkbo
Copy link
Owner

vkbo commented Jul 9, 2025

I pushed a commit that checks for the correct qtlrelease exec. This is useful in general for building on Fedora, not just in CI/CD. I also fixed a bug in your yaml (it was invalid).

The Fedora test job fails on pulling the docker image though.

@vkbo
Copy link
Owner

vkbo commented Jul 9, 2025

The Codecov command failed. Seems it needs git to be installed.

@vkbo
Copy link
Owner

vkbo commented Jul 9, 2025

Also, the two commented out sed commands seem to be unnecessary, and can be removed.

@vkbo vkbo marked this pull request as draft July 9, 2025 15:49
@vkbo vkbo changed the title WIP: Test on Fedora linux Test on Fedora linux Jul 9, 2025
@vkbo
Copy link
Owner

vkbo commented Jul 9, 2025

If this will be useful, can add a build_rpm.py script within the utils directory.

Do you want to do that in the same pull request, or another one?

I flagged the PR as a Draft (same as the WIP prefix in GitLab), but the tests can be merged as they are now if you're happy with the setup. Looks good to me anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create RPM packages on GitHub

2 participants