Pass effective proxy to XClIdGen - #319
Merged
Merged
Conversation
Owner
|
Thanks, this is a great improvement! Congrats on your first contribution to twscrape 🎉 |
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pass the effective account proxy to the
XClIdGenasset client.Previously, GraphQL requests could use the configured account/API proxy, but
XClIdGen.create()created a separate HTTP client withoutproxy settings. That client fetches
x.comandabs.twimg.comassets before the GraphQL request is sent, so requests could fail inenvironments where direct access to those hosts is blocked or unstable even when the account proxy works.
This change:
Account.resolve_proxy()to reuse the same proxy resolution order asAccount.make_client()XClIdGen.create()XClIdGenStorecache key to avoid reusing generators across different proxy contextsTests
uv run pytestuv run ruff check .uv run ty check