fix: use account cookies for XClId asset requests - #321
Merged
Conversation
peaceplayer0722
pushed a commit
to peaceplayer0722/twscrape
that referenced
this pull request
Jul 21, 2026
X now serves a web bundle without the sign.o-*.js / ondemand.s-*.js indices script to anonymous sessions, so the anonymous fetch in XClIdGen.create failed with "Couldn't get XClientTxId indices script" and every GraphQL request 404'd. Thread account cookies through XClIdGenStore.get -> XClIdGen.create so the fetch runs under the account's authenticated session. Ref: vladkens#321
gepard-me
pushed a commit
to gepard-me/twscrape
that referenced
this pull request
Jul 21, 2026
X now serves a web bundle without the sign.o-*.js / ondemand.s-*.js indices script to anonymous sessions, so the anonymous fetch in XClIdGen.create failed with "Couldn't get XClientTxId indices script" and every GraphQL request 404'd. Thread account cookies through XClIdGenStore.get -> XClIdGen.create so the fetch runs under the account's authenticated session. Ref: vladkens#321
vladkens
changed the title
XClIdGen.create() to always use authenticated sessions/cookies
Owner
|
Thanks for tracking this down and fixing it! Great first contribution to twscrape 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #320 that was causing the following error:
Changes
XClIdGen.create()andXClIdGenStore.get()to use cookies so they fetch from authenticated sessions.main()demo to accept cookies and fail gracefully via warning if unset.Tests
XClIdGen.create()andXClIdGenStore.get()intests/test_xclid.pyandtests/test_queue_client.pyrespectively.