This repository was archived by the owner on Aug 24, 2022. It is now read-only.
Sourcery refactored main branch #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| if self.catalog.get(name): | ||
| return self.catalog.get(name) | ||
| return name | ||
| return self.catalog.get(name) or name |
Author
There was a problem hiding this comment.
Function BringData.convert_name refactored with the following changes:
- Simplify if expression by using or (
or-if-exp-identity) - Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-310
to
+309
| specification = name[name.index(" [") + 2 : len(name) - 1] | ||
| name = name[0 : name.index(" [")] | ||
| specification = name[name.index(" [") + 2:-1] | ||
| name = name[:name.index(" [")] |
Author
There was a problem hiding this comment.
Function ShoppingData.ha_to_shopping_item refactored with the following changes:
- Simplify accessing last index of list (
simplify-negative-index) - Replace a[0:x] with a[:x] and a[x:len(a)] with a[x:] (
remove-redundant-slice-index)
Comment on lines
-342
to
+341
| specification = name[name.index(" [") + 2 : len(name) - 1] | ||
| name = name[0 : name.index(" [")] | ||
| specification = name[name.index(" [") + 2:-1] | ||
| name = name[:name.index(" [")] |
Author
There was a problem hiding this comment.
Function ShoppingData.async_add refactored with the following changes:
- Simplify accessing last index of list (
simplify-negative-index) - Replace a[0:x] with a[:x] and a[x:len(a)] with a[x:] (
remove-redundant-slice-index)
Comment on lines
-374
to
+373
| specification = name[name.index(" [") + 2 : len(name) - 1] | ||
| name = name[0 : name.index(" [")] | ||
| specification = name[name.index(" [") + 2:-1] | ||
| name = name[:name.index(" [")] |
Author
There was a problem hiding this comment.
Function ShoppingData.async_update refactored with the following changes:
- Simplify accessing last index of list (
simplify-negative-index) - Replace a[0:x] with a[:x] and a[x:len(a)] with a[x:] (
remove-redundant-slice-index)
| self.headers = {} | ||
| self.addheaders = {} | ||
| self.session = session if session else ClientSession() | ||
| self.session = session or ClientSession() |
Author
There was a problem hiding this comment.
Function BringApi.__init__ refactored with the following changes:
- Simplify if expression by using or (
or-if-exp-identity)
Comment on lines
-84
to
+85
| message = None | ||
| if result.get("errorCode"): | ||
| message = result.get("error") | ||
|
|
||
| raise Exception(message if message else result) | ||
| message = result.get("error") if result.get("errorCode") else None | ||
| raise Exception(message or result) |
Author
There was a problem hiding this comment.
Function BringApi.check_response refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp) - Move setting of default value for variable into
elsebranch (introduce-default-else) - Simplify if expression by using or (
or-if-exp-identity)
Comment on lines
-279
to
+283
| for val, key in self.load_translations(locale).items(): | ||
| if key == item: | ||
| return val | ||
| return item | ||
| return next( | ||
| ( | ||
| val | ||
| for val, key in self.load_translations(locale).items() | ||
| if key == item | ||
| ), | ||
| item, | ||
| ) |
Author
There was a problem hiding this comment.
Function BringApi.translate_to_ch refactored with the following changes:
- Use the built-in function
nextinstead of a for-loop (use-next)
Comment on lines
-50
to
+52
| "These are the top {} items on your shopping list: {}".format( | ||
| min(len(items), 5), | ||
| ", ".join(itm["name"] for itm in reversed(items)), | ||
| ) | ||
| f'These are the top {min(len(items), 5)} items on your shopping list: {", ".join((itm["name"] for itm in reversed(items)))}' | ||
| ) | ||
|
|
Author
There was a problem hiding this comment.
Function ListTopItemsIntent.async_handle refactored with the following changes:
- Replace call to format with f-string. (
use-fstring-for-formatting)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!