Applies merge base commit logic to fast-check pipeline#231
Open
dougbtv wants to merge 1 commit intovllm-project:mainfrom
Open
Applies merge base commit logic to fast-check pipeline#231dougbtv wants to merge 1 commit intovllm-project:mainfrom
dougbtv wants to merge 1 commit intovllm-project:mainfrom
Conversation
See also: vllm-project#230 This is in follow up to that PR. Signed-off-by: dougbtv <dosmith@redhat.com>
dougbtv
force-pushed
the
fastcheck-merge-base
branch
from
52bf899 to
7d4fcc8
Compare
debroy-rh
approved these changes
Dec 4, 2025
Collaborator
debroy-rh
left a comment
debroy-rh
left a comment
There was a problem hiding this comment.
Looks good. thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also: #230
This is in follow up to that PR.
Example failure in: https://buildkite.com/vllm/fastcheck/builds/44884#019ae621-177c-4f63-8ddb-7b03de2979b4/128-3322 where we see a 404.
big thanks for @debroy-rh for discovering and raising the issue!