Open
Conversation
Alexei-V-Ivanov-AMD
requested changes
Jan 9, 2026
Collaborator
There was a problem hiding this comment.
I'm looking at the test group definition and it looks like a mixture of commands that should be run "bare-metal" (i.e. through the run-multi-node-test.sh, which spawns the provided container image for each of the two nodes) and things, like pytest invocations that are supposed to be running inside a single container (i.e. our standard testing path we do for all other tests).
Both single-image pytests are succeeding in my local run, as well as two first 2-node tests, however, the third is failing for me locally.
We need to change this PR to enable correct execution of the "2 Node Tests (4 GPUs in total) " test group.
Signed-off-by: charlifu <charlifu@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to enable 2 node test by updating the command to use run-multi-node-test.sh when the
step.num_nodes >= 2.