[RFC] Automated Upstream CI Testing for ci-infra Changes#301
Draft
[RFC] Automated Upstream CI Testing for ci-infra Changes#301
Conversation
Signed-off-by: Tahmid Muttaki <tmuttaki@redhat.com>
84e2147 to
91b427f
Compare
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This RFC implements automated upstream CI testing using GitHub Actions and Buildkite's official integration. It requires one-time setup and provides opt-in automated testing via PR labels.
Background
Currently, testing ci-infra changes requires manual steps:
VLLM_CI_BRANCH=<branch-name>This is inefficient, and provides poor visibility into test results.
Solution
This RFC introduces automated upstream CI testing triggered via GitHub Actions when ci-infra PRs are labeled.
Key principles:
main)What Changed
New GitHub Actions Workflow
File:
.github/workflows/trigger-vllm-buildkite.ymlTriggers:
ci-run-allorci-fast-check-onlylabel is presentBehavior:
buildkite/trigger-pipeline-action@v2.4.1VLLM_CI_BRANCH=<ci-infra-pr-branch>environment variableRequired Setup
Before this workflow can function, the following one-time setup is required by maintainers:
ci-run-allci-fast-check-onlyBenefits
Future Enhancements
Potential follow-ups (not in this RFC):