Consolidate device-to-queue mapping into constants.py#317
Open
Consolidate device-to-queue mapping into constants.py#317
Conversation
Replace the 45-line if-elif chain in get_agent_queue() with a dict lookup against DEVICE_TO_QUEUE in constants.py. Also removes the duplicate AMD queue mapping from _create_amd_mirror_step(). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEVICE_TO_QUEUEdict inconstants.pythat serves as the single source of truth for mappingDeviceTypetoAgentQueue(covers all 26 device types with straightforward 1:1 mappings)get_agent_queue()with a concise dict lookup againstDEVICE_TO_QUEUE, keeping only the branch-dependent docker logic and GPU-count fallback as special cases_create_amd_mirror_step(), replacing it with aDEVICE_TO_QUEUE.get()callTest plan
num_devices2 or 4 (and no explicit device type) still fall back toGPU_4GPU_1still works for unrecognized devices🤖 Generated with Claude Code