Open
Conversation
Replace three large template dicts with shared constants (_COMMON_ENV, _COMMON_VOLUME_MOUNTS, _COMMON_VOLUMES) and a _build_k8s_template() builder function. Also fixes inconsistent .value comparison and adds error handling for unsupported device types. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
h100_plugin_template,nebius_h200_plugin_template,a100_plugin_template) with shared constants (_COMMON_ENV,_COMMON_VOLUME_MOUNTS,_COMMON_VOLUMES) and a_build_k8s_template()builder functionDeviceType.A100.valuewas used instead ofDeviceType.A100(inconsistent with other comparisons and would never match sincestep.deviceis aDeviceTypeenum)ValueErrorfor unsupported device types instead of silently leavingpluginasNoneand crashing withTypeErroron line 140Test plan
🤖 Generated with Claude Code