[5/n][pipeline-gen] Helper method to determine whether test should automatically run#41
[5/n][pipeline-gen] Helper method to determine whether test should automatically run#41
Conversation
|
|
||
| from .step import TestStep | ||
|
|
||
| def step_should_run(step: TestStep, run_all: bool, list_file_diff: List[str]) -> bool: |
There was a problem hiding this comment.
where do these input args come from? I feel that without the context, this function (and the test) does not really serve much purpose.
you should put a more meaningful TestSteps into context, and test with that.
like there are many other fields in TestStep? why does this function need to send the entire TestStep in together? why is this not a member function of TestStep but a standalone function? why run_all does not really "run all", but will skip the optional ones?
aslonnie
left a comment
aslonnie
left a comment
There was a problem hiding this comment.
do you have a PR that has everything together that I can have a look first?
This is the PR with everything together: #36 |
aslonnie
left a comment
aslonnie
left a comment
There was a problem hiding this comment.
talked offline. next step:
- could we have a basic setup of running the high-level thing e2e? like with an example dir with the input files and make it clear that these files are the input files?
- and then, maybe in the same PR, have code that parses the input files into
TestStep?
by having that first, we set up the context for the test step filtering logic in this PR.
2 participants
Determine if test should automatically run based on these logic:
run_allis true)run_allis specified, test runslist_file_diffmatch with source file dependencies, test runs