Document the CI environment variables and their defaults - #431
Open
Hoiyeuhng wants to merge 1 commit into
Open
Conversation
Hoiyeuhng
force-pushed
the
docs/clarify-ci-readme
branch
from
July 22, 2026 19:57
449eae2 to
73bda60
Compare
Hoiyeuhng
force-pushed
the
docs/clarify-ci-readme
branch
3 times, most recently
from
August 29, 2026 04:36
7e8503f to
9dced72
Compare
Give the environment variable table a Default column, correct the entries that stated no default or the wrong one, and add TORCH_NIGHTLY, CONTINUE_ON_FAILURE and VLLM_CI_ONLY_STEP_KEYS. Also add the two top-level directories missing from the repository tree. Signed-off-by: Haiyang Luo <41023868+Hoiyeuhng@users.noreply.github.com>
Hoiyeuhng
force-pushed
the
docs/clarify-ci-readme
branch
from
August 29, 2026 04:54
9dced72 to
74efaa5
Compare
Hoiyeuhng
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defaultcolumn and state each variable's actual defaultTORCH_NIGHTLY,CONTINUE_ON_FAILUREandVLLM_CI_ONLY_STEP_KEYS.github/andscripts/, the two top-level directories missing from the repository treeDocumentation only.
git diffandgit diff -wreport identical line counts, so there is no whitespace-only churn here.Why
The table folds defaults into prose for two rows and omits them for the rest, so there is no way to tell whether an unset variable means
0,1, or "the bootstrap decides". Two rows were also inaccurate:RUN_ALLis set by more than an explicit override, andVLLM_USE_PRECOMPILEDis chosen by the bootstrap from wheel availability rather than being a plain1/0switch.Validation
Every row was checked against the code that reads it: the defaults block and label checks in
buildkite/bootstrap-intel.sh;PRIORITY,NOAUTO,SKIP_TIMEOUTandCONTINUE_ON_FAILUREinbuildkite_step.py;VLLM_CI_ONLY_STEP_KEYSinglobal_config.py; and the precompiled-wheel selection inbootstrap-intel.shplusdocker/ci.hcl.bootstrap-intel.shalso assigns a default toVLLM_CI_REPO, but nothing in this repository reads it, so I left it undocumented rather than guessing at its contract.pre-commit run --files README.mdpasses andgit diff --checkis clean.Related
The AMD template input reference fix previously bundled here is now #496.
AI assistance
AI assistance was used to research and prepare this change. The submitter has reviewed every changed line.