refactor(tpu-inference/k8s): collapse duplicated Kueue queue templates - #462
Closed
theminghuang wants to merge 1 commit into
Closed
refactor(tpu-inference/k8s): collapse duplicated Kueue queue templates#462theminghuang wants to merge 1 commit into
theminghuang wants to merge 1 commit into
Conversation
queue_group_manager.yaml.tpl and queue_group_worker.yaml.tpl are identical
apart from the MultiKueue admissionChecksStrategy block. Every change to the
quota model - preemption policy, covered resources, flavor naming - has to be
made twice and kept in sync by hand, and there is nothing that catches a miss.
Replace both with queue_group.yaml.tpl plus an ${ADMISSION_CHECKS}
substitution the generator fills for the manager and leaves empty for workers,
and route both render paths through a shared render_queue_group() helper.
Verified as a pure refactor: regenerating from the committed prod.auto.tfvars
produces byte-identical output for every file under generated/, both the
modular parts and the consolidated bundles.
Also normalises hcl2 object keys. Keys written quoted in tfvars keep their
quotes through the parser and become Kubernetes object names, so a quoted
worker or pool key silently yields a ClusterQueue literally named
"v6e-1-1x1". The current tfvars uses bare identifiers so this is latent
rather than live, but it fails a long way from its cause. Confirmed both
spellings now generate identical manifests.
Adds scripts/requirements.txt; the generator imports hcl2 and nothing declared
it, so it fails with ModuleNotFoundError on a clean checkout.
Signed-off-by: theminghuang <theminghuang@gmail.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Collaborator
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Aug 11, 2026
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
queue_group_manager.yaml.tpl and queue_group_worker.yaml.tpl are identical
apart from the MultiKueue admissionChecksStrategy block. Every change to the
quota model - preemption policy, covered resources, flavor naming - has to be
made twice and kept in sync by hand, and there is nothing that catches a miss.
Replace both with queue_group.yaml.tpl plus an ${ADMISSION_CHECKS}
substitution the generator fills for the manager and leaves empty for workers,
and route both render paths through a shared render_queue_group() helper.
Verified as a pure refactor: regenerating from the committed prod.auto.tfvars
produces byte-identical output for every file under generated/, both the
modular parts and the consolidated bundles.
Also normalises hcl2 object keys. Keys written quoted in tfvars keep their
quotes through the parser and become Kubernetes object names, so a quoted
worker or pool key silently yields a ClusterQueue literally named
"v6e-1-1x1". The current tfvars uses bare identifiers so this is latent
rather than live, but it fails a long way from its cause. Confirmed both
spellings now generate identical manifests.
Adds scripts/requirements.txt; the generator imports hcl2 and nothing declared
it, so it fails with ModuleNotFoundError on a clean checkout.
Signed-off-by: theminghuang theminghuang@gmail.com
Co-Authored-By: Claude Opus 5 noreply@anthropic.com