Skip to content

[Bugfix] Remove constant pruning from 2of4 examples #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 19, 2025

Conversation

kylesayrs
Copy link
Collaborator

@kylesayrs kylesayrs commented Mar 18, 2025

Purpose

  • Remove constant pruning modifier in examples, as it is not effective or necessary

Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@kylesayrs kylesayrs marked this pull request as draft March 18, 2025 23:11
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs kylesayrs changed the title [Bugfix] Remove constant pruning from 2of4 example, do not start on initialize [Bugfix] Remove constant pruning from 2of4 example Mar 18, 2025
rahul-tuli
rahul-tuli previously approved these changes Mar 19, 2025
Copy link
Collaborator

@rahul-tuli rahul-tuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kylesayrs kylesayrs changed the title [Bugfix] Remove constant pruning from 2of4 example [Bugfix] Remove constant pruning from 2of4 examples Mar 19, 2025
@kylesayrs kylesayrs marked this pull request as ready for review March 19, 2025 17:22
@rahul-tuli rahul-tuli merged commit b7d34e0 into main Mar 19, 2025
8 checks passed
@rahul-tuli rahul-tuli deleted the kylesayrs/fix-2of4-start-event branch March 19, 2025 23:38
dsikka pushed a commit that referenced this pull request Mar 20, 2025
We mistakenly also removed `ConstantPruningModifier` from finetuning
examples as a part of #1267

This PR adds it back for fine-tuning examples.

Signed-off-by: Rahul Tuli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants