-
Notifications
You must be signed in to change notification settings - Fork 175
oneshot entrypoint update #1445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! There are a few arguments missing from the signature like dvc_data_repository
, but this is handled and by **kwargs and those arguments don't need to be explicit.
This will go a long way towards making LLM Compressor more user friendly :)
@ved1beta Could you please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @ved1beta for taking a shot at this! I think some of the type hints need to be updated to account for actual classes being passed in other than string representations, but otherwise this is looking great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codereview updates
Once #1493 lands and we rebase, test checks should pass |
SUMMARY: some tests in `tests/llmcompressor/transformers/tracing/test_models.py` requiring access to gated HF hub models will fail for community user PRs, because `HF_TOKEN` is not injected. This just skips the tests in question. This update allows #1446 and #1445 to pass GHA checks so that they can be merged in TEST PLAN: n/a Signed-off-by: Brian Dellabetta <[email protected]>
aca8dce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great change to make
0de621f
SUMMARY: Community user PRs are still failing tracing test checks. This loosens the skip check so it resolves correctly After merge and rebase, this should also resolve issue for #1521 TEST PLAN: Confirmed with @dbarbuzzi that this resolved the issue for #1445 . Signed-off-by: Brian Dellabetta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codereview updates
89ec9ed
SUMMARY:
Updated the oneshot function to use explicit keyword arguments instead of relying solely on **kwargs.
TEST PLAN:
Changes were tested using mock tests that verify:
Correct handling of explicit arguments
Backward compatibility with kwargs
Proper behavior with mixed explicit args and kwargs
Verification that kwargs correctly override explicit parameters when duplicates exist
fixes
#1443
TODO: