Skip to content

oneshot entrypoint update #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jun 17, 2025
Merged

Conversation

ved1beta
Copy link
Contributor

@ved1beta ved1beta commented May 17, 2025

SUMMARY:
Updated the oneshot function to use explicit keyword arguments instead of relying solely on **kwargs.

TEST PLAN:
Changes were tested using mock tests that verify:
Correct handling of explicit arguments
Backward compatibility with kwargs
Proper behavior with mixed explicit args and kwargs
Verification that kwargs correctly override explicit parameters when duplicates exist
fixes
#1443

TODO:

Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@kylesayrs kylesayrs self-requested a review May 17, 2025 14:43
@kylesayrs kylesayrs added the ready When a PR is ready for review label May 17, 2025
kylesayrs
kylesayrs previously approved these changes May 17, 2025
Copy link
Collaborator

@kylesayrs kylesayrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! There are a few arguments missing from the signature like dvc_data_repository, but this is handled and by **kwargs and those arguments don't need to be explicit.

This will go a long way towards making LLM Compressor more user friendly :)

@kylesayrs
Copy link
Collaborator

@ved1beta Could you please make style; make quality?

@dsikka dsikka changed the title onshort function update : ) oneshot entrypoint update May 17, 2025
Copy link
Collaborator

@brian-dellabetta brian-dellabetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ved1beta for taking a shot at this! I think some of the type hints need to be updated to account for actual classes being passed in other than string representations, but otherwise this is looking great!

@brian-dellabetta brian-dellabetta self-requested a review May 20, 2025 20:25
Copy link
Collaborator

@brian-dellabetta brian-dellabetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codereview updates

@brian-dellabetta
Copy link
Collaborator

Once #1493 lands and we rebase, test checks should pass

brian-dellabetta added a commit that referenced this pull request Jun 2, 2025
SUMMARY:
some tests in `tests/llmcompressor/transformers/tracing/test_models.py`
requiring access to gated HF hub models will fail for community user
PRs, because `HF_TOKEN` is not injected. This just skips the tests in
question.

This update allows #1446 and #1445 to pass GHA checks so that they can
be merged in


TEST PLAN:
n/a

Signed-off-by: Brian Dellabetta <[email protected]>
@brian-dellabetta brian-dellabetta dismissed stale reviews from rahul-tuli and themself via aca8dce June 6, 2025 18:13
kylesayrs
kylesayrs previously approved these changes Jun 6, 2025
Copy link
Collaborator

@kylesayrs kylesayrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great change to make

rahul-tuli
rahul-tuli previously approved these changes Jun 6, 2025
@brian-dellabetta brian-dellabetta dismissed stale reviews from rahul-tuli, kylesayrs, and themself via 0de621f June 6, 2025 18:45
brian-dellabetta added a commit that referenced this pull request Jun 16, 2025
SUMMARY:
Community user PRs are still failing tracing test checks. This loosens
the skip check so it resolves correctly

After merge and rebase, this should also resolve issue for #1521 

TEST PLAN:
Confirmed with @dbarbuzzi that this resolved the issue for #1445 .

Signed-off-by: Brian Dellabetta <[email protected]>
Copy link
Collaborator

@brian-dellabetta brian-dellabetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codereview updates

kylesayrs
kylesayrs previously approved these changes Jun 16, 2025
@brian-dellabetta brian-dellabetta dismissed stale reviews from kylesayrs and themself via 89ec9ed June 17, 2025 17:31
@brian-dellabetta brian-dellabetta merged commit a18c76a into vllm-project:main Jun 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready When a PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants