-
Notifications
You must be signed in to change notification settings - Fork 315
Convert AutoAWQ checkpoints to compressed-tensors #2112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @mutichung, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a dedicated utility to bridge the gap between AutoAWQ-quantized models and the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new script to convert AutoAWQ checkpoints into a compressed-tensors-compatible format. The implementation covers loading model weights, dequantizing them according to the AutoAWQ GEMM version, and then re-packing them using ModelCompressor. The script also includes CLI and Python interfaces for conversion. Overall, the changes are well-structured and address the stated objective. However, there are a few areas related to security, correctness, and consistency that could be improved.
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Signed-off-by: Muti Chung <[email protected]>
Signed-off-by: Muti Chung <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Muti Chung <[email protected]>
- Add usage example in module docstring. - Modified what to show on document page. Signed-off-by: Muti Chung <[email protected]>
Signed-off-by: Muti Chung <[email protected]>
Signed-off-by: Muti Chung <[email protected]>
Signed-off-by: Muti Chung <[email protected]>
2f45719 to
f997a80
Compare
Signed-off-by: Muti Chung <[email protected]>
Signed-off-by: Muti Chung <[email protected]>
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a valuable script for converting AutoAWQ checkpoints to the compressed-tensors format. The implementation is well-structured, with clear separation of concerns and good use of existing libraries. However, I've identified a couple of potential issues in the dequantization logic that could lead to incorrect behavior, particularly concerning tensor shapes and the handling of quantization parameters. My review includes suggestions to address these points to ensure the conversion is robust and correct for a wider range of models. The accompanying tests are a great start for validation.
Signed-off-by: Muti Chung <[email protected]>
Summary
This PR introduces a new script to convert AutoAWQ checkpoints into
compressed-tensors-compatible format undermodifiers/awq. Resolves #2087.Usage
Via CLI:
Via Python:
Known Issue
Asymmetric Support in
llm-compressor&compressed-tensorsAutoAWQwith versionGEMMonly supports asymmetric quantization 1.AssertionErrorwill be raised despite settingzero_point=False.PackedQuantizationCompressoris a WIP 2.Test Plan
llmcompressor-compressed model withCompressedLinear.torch.testing.assert_close, potentially due to GEMM kernel's internal precision?AutoAWQForCausalLMand vLLM.compressed-tensorsbased on 3.llmcompressorcheckpoints.ruikangliu/DeepSeek-R1-Distill-Qwen-1.5B-quantized.awq-autoawq-w4g128
AMead10/Llama-3.2-3B-Instruct-AWQ
fbaldassarri/mistralai_Mistral-7B-Instruct-v0.3-autoawq-int4-gs128-asym
Future Work
packed-quantizedonce asymmetric decompression is finalized.AutoModelForCausalLMwith a more generalized autoclass.Footnotes
awq/modules/linear/gemm.py#L187 ↩
[Feature] Support Zero-point Decompression #1704 ↩
compressed-tensors@f9e7426 ↩ ↩2
compressed-tensors@cf5980d ↩