Skip to content

Conversation

@dsikka
Copy link
Collaborator

@dsikka dsikka commented Dec 14, 2025

SUMMARY:
This will make it easier to run the lm-eval tests in two different jobs, one focused on VL models and the other focused on a normal decoder model

@github-actions
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @dsikka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the directory structure for lm-eval configurations by isolating Visual Language (VL) model configurations into their own dedicated folder. This strategic move is designed to simplify the setup and execution of separate test jobs, allowing for more focused and efficient testing of VL models independently from other decoder models.

Highlights

  • Configuration Relocation: Visual Language (VL) model configurations have been moved from the tests/lmeval/configs/ directory to a newly created tests/lmeval/vl_configs/ folder.
  • Improved Test Separation: This reorganization aims to facilitate running lm-eval tests in two distinct jobs: one specifically for VL models and another for standard decoder models, enhancing testing efficiency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

kylesayrs
kylesayrs previously approved these changes Dec 14, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the test configuration by moving the vision-language (VL) model configs into a dedicated vl_configs directory. This is a good organizational change that will make it easier to run tests for VL and non-VL models in separate CI jobs, as you've noted. The changes are limited to file moves, and I've verified that the paths to recipe files within the configs are absolute from the project root, so they won't be broken by this move. The change is sound and looks good to merge.

@dsikka dsikka added the ready When a PR is ready for review label Dec 14, 2025
@dsikka dsikka requested a review from dhuangnm December 14, 2025 21:35
@dsikka
Copy link
Collaborator Author

dsikka commented Dec 14, 2025

@dhuangnm could we separate the lm-eval test into two jobs as well, one which runs on the configs folder and one which works on the vl_configs folder? This should prevent future timeouts as well as during release

Copy link
Collaborator

@dhuangnm dhuangnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsikka dsikka merged commit 8cfb5ec into main Dec 15, 2025
11 checks passed
@dsikka dsikka deleted the update_lmeval_configs branch December 15, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready When a PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants