-
Notifications
You must be signed in to change notification settings - Fork 315
[Example] MedGemma #2126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Example] MedGemma #2126
Conversation
Signed-off-by: Kyle Sayers <[email protected]>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Summary of ChangesHello @kylesayrs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new example for quantizing the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new example script for quantizing the MedGemma model. The script is well-structured, but it contains a critical issue in how oneshot is called for a multimodal model. The current implementation will fail because it lacks a proper data collator for image and text data, and it passes a tokenizer string instead of the required processor object. I've provided a detailed comment with a code suggestion to fix this, which includes adding a data collator and updating the oneshot parameters. With this change, the example should run correctly.
| # Perform oneshot | ||
| oneshot( | ||
| model=model, | ||
| tokenizer=model_id, | ||
| dataset=DATASET_ID, | ||
| splits=DATASET_SPLIT, | ||
| recipe=recipe, | ||
| max_seq_length=MAX_SEQUENCE_LENGTH, | ||
| num_calibration_samples=NUM_CALIBRATION_SAMPLES, | ||
| trust_remote_code_model=True, | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The oneshot call is not correctly configured for this multimodal model and will likely fail during execution. There are two main issues:
- Missing data collator: The default data collator only handles text. For a multimodal dataset like
flickr30k, a customdata_collatoris required to process both images and text. - Incorrect processor handling: The
processorobject should be passed tooneshot, not atokenizerstring, to ensure both modalities are handled correctly during data loading and calibration.
Below is a suggested change that defines a data collator and corrects the oneshot call.
def data_collator(data):
images = [sample["images"] for sample in data]
text = [sample["text"] for sample in data]
return processor(text=text, images=images, padding=True, return_tensors="pt")
# Perform oneshot
oneshot(
model=model,
processor=processor,
dataset=DATASET_ID,
splits=DATASET_SPLIT,
recipe=recipe,
data_collator=data_collator,
max_seq_length=MAX_SEQUENCE_LENGTH,
num_calibration_samples=NUM_CALIBRATION_SAMPLES,
trust_remote_code_model=True,
)
Purpose
Changes
Testing