Adding test_group to lm-eval configs#2623
Adding test_group to lm-eval configs#2623debroy-rh wants to merge 7 commits intovllm-project:mainfrom
Conversation
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughAdded a new top-level configuration field Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request adds the "test_group: rhaiis" field to several YAML configuration files in the tests/lmeval directory. Feedback highlights that the run_tests_in_rhaiis.sh script requires updates to correctly resolve the paths for these configuration files and to refine the model name extraction logic to handle nested keys in Vision-Language configurations.
| @@ -1,4 +1,5 @@ | |||
| cadence: "weekly" | |||
| test_group: "rhaiis" | |||
There was a problem hiding this comment.
The run_tests_in_rhaiis.sh script (line 53) contains a hardcoded path prefix ${script_path}/configs/ which resolves to tests/e2e/vLLM/configs/. Since this configuration file is located in tests/lmeval/configs/, the script will fail to find it even if the correct directory is passed via the -c flag. The script should be updated to use the provided $CONFIG path instead of the hardcoded one: for MODEL_CONFIG in $(echo -e "$CONFIGS" | sed "s|^|${CONFIG}/|").
| @@ -1,4 +1,5 @@ | |||
| cadence: "weekly" | |||
| test_group: "rhaiis" | |||
There was a problem hiding this comment.
The run_tests_in_rhaiis.sh script (line 59) uses grep 'model:' to extract the model name. For Vision-Language (VL) configurations like this one, there is typically a nested model key under the lmeval section (e.g., model: "hf-multimodal"). This causes the grep command to return multiple lines, which breaks the $model variable and the subsequent save_dir construction. The script should be updated to use a more specific pattern, such as grep '^model:', to only match the top-level key.
dsikka
left a comment
There was a problem hiding this comment.
I think RHAIIS testing should use vLLM lm-eval testing, not HF as is currently used
This is something we are going to update in upstream soon but definitely what we should use for product release
dhuangnm
left a comment
There was a problem hiding this comment.
It LGTM in general, just one question about a model config.
I think this PR needs to land along with the corresponding changes in the llm-compressor-testing repo. @debroy-rh can you please create the PR for the llm-compressor-testing repo as well so we can test the two PRs together before landing? Thanks.
Signed-off-by: Debolina Roy <debroy@redhat.com>
Signed-off-by: Debolina Roy <debroy@redhat.com>
Signed-off-by: Debolina Roy <debroy@redhat.com>
2cb940a to
2565420
Compare
Signed-off-by: Debolina Roy <debroy@redhat.com>
Signed-off-by: Debolina Roy <debroy@redhat.com>
Signed-off-by: Debolina Roy <debroy@redhat.com>
Signed-off-by: Debolina Roy <debroy@redhat.com>
|
@dhuangnm , @dsikka - I was trying to run the the lm-eval for vl_configs - [vl_w4a16_actorder_weight.yaml]. It was failing. Two reasons -
Please take a look. |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Require two reviewsWaiting for:
This rule is failing.PRs labelled "two-reviews" must have at least two approving reviews before merging.
|
Adding test_group to the following lm-eval configs:
fp8_dynamic_per_token.yaml
w4a4_nvfp4.yaml
w4a16_actorder_none.yaml
vl_w4a16_actorder_weight.yaml
This is to test rhaiis model-opt image for lm-eval accuracy.