Bump Kubernetes client to 36.0.3 - #1014
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the dependency versions of aiohttp and kubernetes in pyproject.toml. The review feedback points out that these dependency updates should also be applied to src/vllm_router/requirements.txt to avoid dependency drift and potential runtime issues.
arnaudgeiser
force-pushed
the
bump-kubernetes-client
branch
from
July 24, 2026 13:14
e24b01b to
3677880
Compare
ruizhang0101
approved these changes
Jul 28, 2026
loicrouillermonay
force-pushed
the
bump-kubernetes-client
branch
from
July 28, 2026 21:28
3677880 to
b6c32cf
Compare
|
@ruizhang0101 I went ahead and rebased the branch on Arnaud's behalf as I'm affiliated with Exoscale. You can now approve the CI workflow to run 😉 |
ruizhang0101
enabled auto-merge (squash)
July 29, 2026 18:34
Signed-off-by: Arnaud Geiser <arnaud.geiser@exoscale.ch>
auto-merge was automatically disabled
August 3, 2026 07:30
Head branch was pushed to by a user without write access
loicrouillermonay
force-pushed
the
bump-kubernetes-client
branch
from
August 3, 2026 07:30
b6c32cf to
50d3037
Compare
loicrouillermonay
requested review from
ApostaC,
Shaoting-Feng and
YuhanLiu11
as code owners
August 3, 2026 07:30
ruizhang0101
enabled auto-merge (squash)
August 3, 2026 07:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent Kubernetes versions >1.32.0 have seen a lot of changes regarding how the watches are being handled.
The official library also had a lot of improvements.
Bumping the library typically solves the following issue [1] for us because we are using Kubernetes 1.36.0.
[1] : #999