Skip to content

[CI/Build] Scope Shaoting-Feng's code ownership to router, observability, and benchmarks - #1046

Merged
ruizhang0101 merged 2 commits into
vllm-project:mainfrom
Shaoting-Feng:codeowners-router-observability-benchmarks
Aug 29, 2026
Merged

[CI/Build] Scope Shaoting-Feng's code ownership to router, observability, and benchmarks#1046
ruizhang0101 merged 2 commits into
vllm-project:mainfrom
Shaoting-Feng:codeowners-router-observability-benchmarks

Conversation

@Shaoting-Feng

Copy link
Copy Markdown
Collaborator

Summary

Scopes @Shaoting-Feng's code ownership to the router, observability, and benchmarks areas instead of the repo-wide default introduced in #1011.

Changes

  • Remove @Shaoting-Feng from the default * owners line
  • Add @Shaoting-Feng as an owner of /src/vllm_router/, /observability/, and /benchmarks/
  • The default owners are re-listed on those three paths because the last matching CODEOWNERS pattern takes precedence, so their coverage is unchanged

Testing

Verified by visual inspection: the three paths exist in the repo, and the file has no trailing whitespace and ends with a single newline (the pre-commit hooks that apply to this file).


  • Make sure the code changes pass the pre-commit checks.
  • Sign-off your commit by using -s when doing git commit
  • Try to classify PRs for easy understanding of the type of changes, such as [Bugfix], [Feat], and [CI].

…ity, and benchmarks

Signed-off-by: Shaoting Feng <stfeng@cs.washington.edu>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .github/CODEOWNERS file by removing @Shaoting-Feng from the default global owners and instead assigning them to specific directories, including /src/vllm_router/, /observability/, and /benchmarks/. There are no review comments, so no additional feedback is provided.

Signed-off-by: Shaoting Feng <stfeng@cs.washington.edu>

@ruizhang0101 ruizhang0101 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruizhang0101
ruizhang0101 merged commit 929a946 into vllm-project:main Aug 29, 2026
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants