[CI/Build] Request one GPU per replica in the two-pods Helm functionality test - #1047
Merged
ruizhang0101 merged 1 commit intoAug 29, 2026
Merged
Conversation
…lity test Signed-off-by: Shaoting Feng <stfeng@cs.washington.edu>
Shaoting-Feng
requested review from
ApostaC,
YuhanLiu11 and
ruizhang0101
as code owners
August 22, 2026 10:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two-Pods-Minimal-Examplein the Helm functionality workflow fails intermittently: one of the two vLLM replicas exits at ~80–90 s, restarts, and the validation step then overruns its 3-minute timeout a few seconds after printingRequests were successful.(e.g. run 32555187470, run 32516740201). Root cause: the two replicas end up sharing one GPU and vLLM's startup memory profiling sees each other's allocations.Why
tests/assets/values-01-2pods-minimal-example.yamlsetsrequestGPU: 0.5. The chart only renders a GPU request/limit whenint(requestGPU) > 0(chart.resources/chart.hasLimitsinhelm/templates/_helpers.tpl), so0.5silently becomes no GPU request at all. Both pods see every GPU on the runner and both pickcuda:0; the runner's second L4 is never used.Both engines finish loading at the same moment and run vLLM's memory profiling concurrently. vLLM measures device-wide free memory, so whichever replica allocates its ~7.7 GiB KV cache first gets charged against the sibling's
--gpu-memory-utilization 0.4budget. Reproduced on the CI runner with the unmodified values file — 10 trials, 5/10 showed the squeeze, e.g. same second, same GPU:Available KV cache memory: 7.69 GiBAvailable KV cache memory: 0.24 GiB … Replace gpu_memory_utilization config with --kv-cache-memory=-263896780 (-0.25 GiB)Two trials went down to 0.06 GiB (a 1,712-token KV cache) — roughly 25 MiB from the point where vLLM can no longer fit one
max_model_len=1024request, raisesValueError, and the engine exits → container restart → the CI signature above. The "squeezed but alive" cases pass CI on a crippled engine.It is not a real OOM (GPU 0 peaks at ~18 of 23 GB) and not the shared HF cache (no errors in any engine log). Healthy single-engine startup is stable at ~90 s, so the 3-minute step budget is fine once the restart goes away.
Changes
requestGPU: 0.5→1so each replica gets its ownnvidia.com/gpuand the two engines no longer profile against each other. The runner has two L4s, andvalues-04-multiple-models.yamlin the same workflow already schedules two engines withrequestGPU: 1each.--gpu-memory-utilization 0.4is left as is.tutorials/assets/values-01-2pods-minimal-example.yaml(same0.5, but user-facing). The chart silently truncating fractionalrequestGPUto "no GPU request" deserves its own follow-up (template guard and/or docs).Testing
Two-Pods-Minimal-Examplein this PR's CI run exercises the changed file directly._helpers.tpl, integerrequestGPUrendersnvidia.com/gpu: "1"under bothrequestsandlimits.Related: #1030, #1036.
-swhen doinggit commit[Bugfix],[Feat], and[CI].